From: "Andreas Färber" <afaerber@suse.de>
To: Aurelien Jarno <aurelien@aurel32.net>,
James Hogan <james.hogan@imgtec.com>
Cc: Sanjay Lal <sanjayl@kymasys.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] hw/mips: gt64xxx_pci: Add VMStateDescription
Date: Fri, 20 Jun 2014 14:56:41 +0200 [thread overview]
Message-ID: <53A42F89.6060503@suse.de> (raw)
In-Reply-To: <20140620105837.GB12011@ohm.rr44.fr>
Am 20.06.2014 12:58, schrieb Aurelien Jarno:
> Thanks for this new version, I'll apply it in the next days unless
> someone comes with good arguments why we should not do that.
>
> Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
No objection to the code, I just think that "hw/mips:" is redundant in
the subject, although there's no precedent yet.
http://git.qemu-project.org/?p=qemu.git;a=history;f=hw/mips/gt64xxx_pci.c;h=6398514c99d2b15cd047149c8457717e352e9347;hb=HEAD
Same applies to the other MIPS patch.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2014-06-20 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 10:25 [Qemu-devel] [PATCH v3] hw/mips: gt64xxx_pci: Add VMStateDescription James Hogan
2014-06-20 10:33 ` James Hogan
2014-06-20 10:58 ` Aurelien Jarno
2014-06-20 11:12 ` Paolo Bonzini
2014-06-20 12:56 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A42F89.6060503@suse.de \
--to=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=james.hogan@imgtec.com \
--cc=qemu-devel@nongnu.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.