From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Keir Fraser <keir@xen.org>,
IanJackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] slightly consolidate code in free_domheap_pages()
Date: Fri, 20 Jun 2014 15:35:49 +0100 [thread overview]
Message-ID: <53A446C5.7030408@citrix.com> (raw)
In-Reply-To: <53A46004020000780001C008@mail.emea.novell.com>
On 20/06/14 15:23, Jan Beulich wrote:
>> Unrelated to the content of the patch, I can't see a codepath where we
>> would relinquish domain memory from a clean shutdown without setting
>> d->is_dying. Does this mean that we are even scrubbing pages from
>> cleanly shut down domains?
> Yes, just like the comment says.
>
> Jan
>
But it means that we will scrub all pages for all domains no matter how
it died, which is contrary to the statement in the comment which says
that we don't scrub a cleanly shut down domain.
>From what I can see, the only pages Xen won't scrub are pages handed
back via decrease reservation, but I don't see how that is relevant in
this context.
~Andrew
next prev parent reply other threads:[~2014-06-20 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 12:40 [PATCH] slightly consolidate code in free_domheap_pages() Jan Beulich
2014-06-20 13:16 ` Andrew Cooper
2014-06-20 14:23 ` Jan Beulich
2014-06-20 14:35 ` Andrew Cooper [this message]
2014-06-20 14:43 ` Jan Beulich
2014-06-24 10:04 ` Ian Campbell
2014-06-24 10:25 ` Jan Beulich
2014-06-24 11:27 ` Ian Campbell
2014-06-24 11:53 ` Jan Beulich
2014-06-24 12:10 ` Ian Campbell
2014-06-24 12:25 ` Jan Beulich
2014-06-24 12:35 ` Ian Campbell
2014-06-24 12:36 ` [PATCH v2] " Jan Beulich
2014-06-24 12:37 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A446C5.7030408@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.