From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] slightly consolidate code in free_domheap_pages() Date: Fri, 20 Jun 2014 15:35:49 +0100 Message-ID: <53A446C5.7030408@citrix.com> References: <53A447C9020000780001BF5F@mail.emea.novell.com> <53A43433.3070900@citrix.com> <53A46004020000780001C008@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wxzv0-0004vD-Ie for xen-devel@lists.xenproject.org; Fri, 20 Jun 2014 14:35:54 +0000 In-Reply-To: <53A46004020000780001C008@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Campbell , xen-devel , Keir Fraser , IanJackson , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 20/06/14 15:23, Jan Beulich wrote: >> Unrelated to the content of the patch, I can't see a codepath where we >> would relinquish domain memory from a clean shutdown without setting >> d->is_dying. Does this mean that we are even scrubbing pages from >> cleanly shut down domains? > Yes, just like the comment says. > > Jan > But it means that we will scrub all pages for all domains no matter how it died, which is contrary to the statement in the comment which says that we don't scrub a cleanly shut down domain. >>From what I can see, the only pages Xen won't scrub are pages handed back via decrease reservation, but I don't see how that is relevant in this context. ~Andrew