Re: [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

On 06/19/2014 11:55 PM, Hu Tao wrote:
> "0x1-0x10" looks better than "0x1-10"
> 
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  qapi/string-output-visitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c
> index e9aca3b..1ab8574 100644
> --- a/qapi/string-output-visitor.c
> +++ b/qapi/string-output-visitor.c
> @@ -98,7 +98,7 @@ static void format_string(StringOutputVisitor *sov, Range *r, bool next,
>  {
>      if (r->end - r->begin > 1) {
>          if (human) {
> -            g_string_append_printf(sov->string, "0x%" PRIx64 "-%" PRIx64,
> +            g_string_append_printf(sov->string, "0x%" PRIx64 "-0x%" PRIx64,
>                                     r->begin, r->end - 1);
>  
>          } else {
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]