From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:54930 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754510AbaFTPoz (ORCPT ); Fri, 20 Jun 2014 11:44:55 -0400 Message-ID: <53A456F3.4000500@fb.com> Date: Fri, 20 Jun 2014 08:44:51 -0700 From: Josef Bacik MIME-Version: 1.0 To: Mark Fasheh , , , Chris Mason Subject: Re: btrfs: qgroup: account shared subtrees during snapshot delete References: <1403214567-3137-1-git-send-email-mfasheh@suse.de> <1403214567-3137-3-git-send-email-mfasheh@suse.de> <53A36348.4010106@fb.com> <20140619231626.GQ5484@wotan.suse.de> <53A36F85.60607@fb.com> <20140620112534.GB1553@twin.jikos.cz> <20140620152958.GR5484@wotan.suse.de> In-Reply-To: <20140620152958.GR5484@wotan.suse.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 06/20/2014 08:29 AM, Mark Fasheh wrote: > On Fri, Jun 20, 2014 at 01:25:34PM +0200, David Sterba wrote: >> On Thu, Jun 19, 2014 at 04:17:25PM -0700, Josef Bacik wrote: >>>>> We don't pay attention to the return value, we should probably abort the >>>>> transaction if there is a problem. >>>> >>>> Abort or log an error and continue? I ask because technically we could >>>> continue with the subvolume drop but obviously qgroup state will need to be >>>> fixed via a future rescan. I guess the question is which is more 'friendly' >>>> to the user. >>> >>> I'd be ok with log an error and tell the user to rescan. Thanks, >> >> I agree. > > Great, I went ahead and did that. Below is patch #2 with all review comments > implemented. > Looks good, you can add Reviewed-by: Josef Bacik However I'd like to see an xfstest or two for this case so we're sure to be testing everything properly. Once we have that we can merge it. Thanks, Josef