All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Hansen <dave@sr71.net>, linux-kernel@vger.kernel.org
Cc: bp@alien8.de, x86@kernel.org
Subject: Re: [RFC][PATCH 1/3] x86: introduce disabled-features
Date: Fri, 20 Jun 2014 09:20:45 -0700	[thread overview]
Message-ID: <53A45F5D.90505@zytor.com> (raw)
In-Reply-To: <20140620161736.D6AC16FD@viggo.jf.intel.com>

On 06/20/2014 09:17 AM, Dave Hansen wrote:
> diff -puN /dev/null arch/x86/include/asm/disabled-features.h
> --- /dev/null	2014-04-10 11:28:14.066815724 -0700
> +++ b/arch/x86/include/asm/disabled-features.h	2014-06-20 09:15:38.968987152 -0700
> @@ -0,0 +1,33 @@
> +#ifndef _ASM_X86_DISABLED_FEATURES_H
> +#define _ASM_X86_DISABLED_FEATURES_H
> +
> +/* These features, although they might be available in a CPU
> + * will not be used because the compile options to support
> + * them are not present.
> + *
> + * This code allows them to be checked and disabled at
> + * compile time withut an explicit #ifdef.  Simply call
> + * cpu_has() or this_cpu_has().
> + * */
> +
> +#ifdef CONFIG_X86_INTEL_MPX
> +# define HAVE_MPX	(1<<(X86_FEATURE_MPX & 31))
> +#else
> +# define HAVE_MPX	0
> +#endif
> +

Is this an inverted test?

	-hpa


  parent reply	other threads:[~2014-06-20 16:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 16:17 [RFC][PATCH 1/3] x86: introduce disabled-features Dave Hansen
2014-06-20 16:17 ` [RFC][PATCH 2/3] x86: add more disabled features Dave Hansen
2014-06-20 16:17 ` [RFC][PATCH 3/3] x86: make MP a required-feature on 64-bit Dave Hansen
2014-06-20 16:23   ` H. Peter Anvin
2014-06-20 16:30     ` Dave Hansen
2014-06-20 16:37       ` H. Peter Anvin
2014-06-20 17:43         ` Borislav Petkov
2014-06-20 17:47           ` H. Peter Anvin
2014-06-20 18:05             ` Borislav Petkov
2014-06-20 18:16               ` Dave Jones
2014-06-20 18:48                 ` Borislav Petkov
2014-06-20 18:54               ` H. Peter Anvin
2014-06-20 20:00                 ` Borislav Petkov
2014-06-20 20:22                   ` H. Peter Anvin
2014-06-20 20:35                     ` Borislav Petkov
2014-06-20 17:50           ` H. Peter Anvin
2014-06-20 18:15             ` Borislav Petkov
2014-06-20 18:57               ` H. Peter Anvin
2014-06-20 20:37                 ` Borislav Petkov
2014-06-23  6:11         ` Andi Kleen
2014-06-20 16:20 ` H. Peter Anvin [this message]
2014-06-20 17:20   ` [RFC][PATCH 1/3] x86: introduce disabled-features Dave Hansen
2014-06-20 20:40 ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A45F5D.90505@zytor.com \
    --to=hpa@zytor.com \
    --cc=bp@alien8.de \
    --cc=dave@sr71.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.