From: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, U-boot, 1/2] common: cmd_nand: add nand ecclayout command
Date: Fri, 20 Jun 2014 20:02:48 +0300 [thread overview]
Message-ID: <53A46938.8020605@ti.com> (raw)
In-Reply-To: <1403281870.12851.194.camel@snotra.buserror.net>
On 06/20/2014 07:31 PM, Scott Wood wrote:
> On Fri, 2014-06-20 at 16:29 +0300, Ivan Khoronzhuk wrote:
>> On 06/20/2014 04:00 AM, Scott Wood wrote:
>>> On Fri, May 16, 2014 at 09:26:36PM +0300, Khoronzhuk, Ivan wrote:
>>>> + } else {
>>>> + printf("Setting current device"
>>>> + " to ecc layout %d FAILED!\n", idx);
>>> Don't wrap user-visible strings (checkpatch should have warned you about
>>> this).
>> For user's eyes it's not wrapped.
> That's not the point. Wrapping it in the source means the user can't
> grep for the string. Checkpatch should have issued a warning about
> this. This is an exception to the 80 column rule.
>
> -Scott
>
>
Ok.
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2014-06-20 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 18:26 [U-Boot] [U-boot] [Patch 0/2] keystone: nand: add additional nand ecclayout Ivan Khoronzhuk
2014-05-16 18:26 ` [U-Boot] [U-boot] [Patch 1/2] common: cmd_nand: add nand ecclayout command Ivan Khoronzhuk
2014-06-20 1:00 ` [U-Boot] [U-Boot, U-boot, " Scott Wood
2014-06-20 13:29 ` Ivan Khoronzhuk
2014-06-20 14:10 ` Jon Loeliger
2014-06-20 16:03 ` Scott Wood
2014-06-20 17:10 ` Ivan Khoronzhuk
2014-06-20 16:31 ` Scott Wood
2014-06-20 17:02 ` Ivan Khoronzhuk [this message]
2014-05-16 18:26 ` [U-Boot] [U-boot] [Patch 2/2] mtd: nand: davinci: allow to change ecclayout by " Ivan Khoronzhuk
2014-06-20 1:07 ` [U-Boot] [U-Boot, U-boot, " Scott Wood
2014-06-20 14:59 ` Ivan Khoronzhuk
2014-06-20 16:22 ` Scott Wood
2014-06-20 16:57 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A46938.8020605@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.