diff for duplicates of <53A5BDB4.5020008@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 0d33ec1..61d06f4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -54,7 +54,8 @@ how about support instead of enablement ? > --- > > Changes in V3 -> ====> - Fixed an endianness bug leading the driver to break on LE. +> ========= +> - Fixed an endianness bug leading the driver to break on LE. > - Fixed a bug that when one of the 'attribute_group' not populated, following > groups attributes were dropped. > - Rewrite the get_sensor_index_attr() function to handle all the error scenarios @@ -64,7 +65,8 @@ how about support instead of enablement ? > - Addressed remaining review comments on V2. > > Changes in v2 -> ======> - Generic use of devm_* functions in hwmon like using devm_kzalloc() for dynamic +> ============= +> - Generic use of devm_* functions in hwmon like using devm_kzalloc() for dynamic > memory request, avoiding the need to explicit free of memory. > Adding 'struct attribute_group' as member of platform data structure to be > populated and then passed to devm_hwmon_device_register_with_groups(). @@ -128,7 +130,8 @@ how about support instead of enablement ? > +++ b/Documentation/hwmon/ibmpowernv > @@ -0,0 +1,41 @@ > +Kernel Driver IBMPOWENV -> +===========> + +> +======================= +> + > +Supported systems: > + * Any recent IBM P servers based on POWERNV platform > + @@ -311,10 +314,10 @@ but useless). > + } > + > + /* Convert temperature to milli-degrees */ -> + if (sdata->type = AMBIENT_TEMP) +> + if (sdata->type == AMBIENT_TEMP) > + x *= 1000; > + /* Convert power to micro-watts */ -> + else if (sdata->type = POWER_INPUT) +> + else if (sdata->type == POWER_INPUT) > + x *= 1000000; > + > + return sprintf(buf, "%u\n", x); @@ -392,9 +395,9 @@ Why _info anyway ? Isn't this an error ? > + } else if (!strcmp(attr_suffix, DT_DATA_ATTR_SUFFIX)) { > + attr_name = "input"; > + } else if (!strcmp(attr_suffix, DT_THRESHOLD_ATTR_SUFFIX)) { -> + if (type = AMBIENT_TEMP) +> + if (type == AMBIENT_TEMP) > + attr_name = "max"; -> + else if (type = FAN) +> + else if (type == FAN) > + attr_name = "min"; > + else > + return -ENOENT; @@ -424,7 +427,7 @@ dev_err please, and drop __func__. > + } > + > + for_each_child_of_node(opal, np) { -> + if (np->name = NULL) +> + if (np->name == NULL) > + continue; > + > + for (type = 0; type < MAX_SENSOR_TYPE; type++) @@ -490,7 +493,7 @@ dev_err. Why are you checking this twice, anyway ? > + } > + > + for_each_child_of_node(opal, np) { -> + if (np->name = NULL) +> + if (np->name == NULL) > + continue; > + > + for (type = 0; type < MAX_SENSOR_TYPE; type++) @@ -498,7 +501,7 @@ dev_err. Why are you checking this twice, anyway ? > + sensor_groups[type].compatible)) > + break; > + -> + if (type = MAX_SENSOR_TYPE) +> + if (type == MAX_SENSOR_TYPE) > + continue; > + > + sensor_id = of_get_property(np, "sensor-id", NULL); @@ -522,7 +525,8 @@ dev_info > + sdata[count].dev_attr.attr.mode = S_IRUGO; > + sdata[count].dev_attr.show = show_sensor; > + -> + pgroups[type]->attrs[sensor_groups[type].attr_count++] > + &sdata[count++].dev_attr.attr; +> + pgroups[type]->attrs[sensor_groups[type].attr_count++] = +> + &sdata[count++].dev_attr.attr; > + } > + > +exit_put_node: @@ -624,9 +628,3 @@ as much value as the name of the driver. > > > - - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 7cf7b01..ef87be8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020140618083250.20069.73848.stgit@localhost.localdomain\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [lm-sensors] [PATCH v3] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperatur\0" - "Date\0Sat, 21 Jun 2014 17:15:32 +0000\0" + "Subject\0Re: [PATCH v3] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature\0" + "Date\0Sat, 21 Jun 2014 10:15:32 -0700\0" "To\0Neelesh Gupta <neelegup@linux.vnet.ibm.com>" linuxppc-dev@lists.ozlabs.org jdelvare@suse.de @@ -65,7 +65,8 @@ "> ---\n" ">\n" "> Changes in V3\n" - "> ====> - Fixed an endianness bug leading the driver to break on LE.\n" + "> =========\n" + "> - Fixed an endianness bug leading the driver to break on LE.\n" "> - Fixed a bug that when one of the 'attribute_group' not populated, following\n" "> groups attributes were dropped.\n" "> - Rewrite the get_sensor_index_attr() function to handle all the error scenarios\n" @@ -75,7 +76,8 @@ "> - Addressed remaining review comments on V2.\n" ">\n" "> Changes in v2\n" - "> ======> - Generic use of devm_* functions in hwmon like using devm_kzalloc() for dynamic\n" + "> =============\n" + "> - Generic use of devm_* functions in hwmon like using devm_kzalloc() for dynamic\n" "> memory request, avoiding the need to explicit free of memory.\n" "> Adding 'struct attribute_group' as member of platform data structure to be\n" "> populated and then passed to devm_hwmon_device_register_with_groups().\n" @@ -139,7 +141,8 @@ "> +++ b/Documentation/hwmon/ibmpowernv\n" "> @@ -0,0 +1,41 @@\n" "> +Kernel Driver IBMPOWENV\n" - "> +===========> +\n" + "> +=======================\n" + "> +\n" "> +Supported systems:\n" "> + * Any recent IBM P servers based on POWERNV platform\n" "> +\n" @@ -322,10 +325,10 @@ "> +\t}\n" "> +\n" "> +\t/* Convert temperature to milli-degrees */\n" - "> +\tif (sdata->type = AMBIENT_TEMP)\n" + "> +\tif (sdata->type == AMBIENT_TEMP)\n" "> +\t\tx *= 1000;\n" "> +\t/* Convert power to micro-watts */\n" - "> +\telse if (sdata->type = POWER_INPUT)\n" + "> +\telse if (sdata->type == POWER_INPUT)\n" "> +\t\tx *= 1000000;\n" "> +\n" "> +\treturn sprintf(buf, \"%u\\n\", x);\n" @@ -403,9 +406,9 @@ "> +\t} else if (!strcmp(attr_suffix, DT_DATA_ATTR_SUFFIX)) {\n" "> +\t\tattr_name = \"input\";\n" "> +\t} else if (!strcmp(attr_suffix, DT_THRESHOLD_ATTR_SUFFIX)) {\n" - "> +\t\tif (type = AMBIENT_TEMP)\n" + "> +\t\tif (type == AMBIENT_TEMP)\n" "> +\t\t\tattr_name = \"max\";\n" - "> +\t\telse if (type = FAN)\n" + "> +\t\telse if (type == FAN)\n" "> +\t\t\tattr_name = \"min\";\n" "> +\t\telse\n" "> +\t\t\treturn -ENOENT;\n" @@ -435,7 +438,7 @@ "> +\t}\n" "> +\n" "> +\tfor_each_child_of_node(opal, np) {\n" - "> +\t\tif (np->name = NULL)\n" + "> +\t\tif (np->name == NULL)\n" "> +\t\t\tcontinue;\n" "> +\n" "> +\t\tfor (type = 0; type < MAX_SENSOR_TYPE; type++)\n" @@ -501,7 +504,7 @@ "> +\t}\n" "> +\n" "> +\tfor_each_child_of_node(opal, np) {\n" - "> +\t\tif (np->name = NULL)\n" + "> +\t\tif (np->name == NULL)\n" "> +\t\t\tcontinue;\n" "> +\n" "> +\t\tfor (type = 0; type < MAX_SENSOR_TYPE; type++)\n" @@ -509,7 +512,7 @@ "> +\t\t\t\t\tsensor_groups[type].compatible))\n" "> +\t\t\t\tbreak;\n" "> +\n" - "> +\t\tif (type = MAX_SENSOR_TYPE)\n" + "> +\t\tif (type == MAX_SENSOR_TYPE)\n" "> +\t\t\tcontinue;\n" "> +\n" "> +\t\tsensor_id = of_get_property(np, \"sensor-id\", NULL);\n" @@ -533,7 +536,8 @@ "> +\t\tsdata[count].dev_attr.attr.mode = S_IRUGO;\n" "> +\t\tsdata[count].dev_attr.show = show_sensor;\n" "> +\n" - "> +\t\tpgroups[type]->attrs[sensor_groups[type].attr_count++] > +\t\t\t\t&sdata[count++].dev_attr.attr;\n" + "> +\t\tpgroups[type]->attrs[sensor_groups[type].attr_count++] =\n" + "> +\t\t\t\t&sdata[count++].dev_attr.attr;\n" "> +\t}\n" "> +\n" "> +exit_put_node:\n" @@ -634,12 +638,6 @@ "> +module_exit(ibmpowernv_exit);\n" ">\n" ">\n" - ">\n" - "\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + > -d94391d52d87215d32aec4bf42514dec0607a04c646667e6027046b7b635fe11 +fe982744201de633c95913b01c46fec0c8039efc8b1d71d046fea670b588c044
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.