From: Felix Fietkau <nbd@openwrt.org>
To: Rostislav Lisovy <lisovy@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michal Sojka <sojkam1@fel.cvut.cz>,
s.sander@nordsys.de, jan-niklas.meier@volkswagen.de,
Rostislav Lisovy <rostislav.lisovy@fel.cvut.cz>
Subject: Re: [PATCH 2/2] cfg80211: Use 5MHz bandwidth by default when checking usable channels
Date: Sun, 22 Jun 2014 13:41:51 +0200 [thread overview]
Message-ID: <53A6C0FF.9090104@openwrt.org> (raw)
In-Reply-To: <1397565476-4348-3-git-send-email-rostislav.lisovy@fel.cvut.cz>
On 2014-04-15 14:37, Rostislav Lisovy wrote:
> Current code checks if the 20MHz bandwidth is allowed for
> particular channel -- if it is not, the channel is disabled.
> Since we need to use 5/10 MHz channels, this code is modified in
> the way that the default bandwidth to check is 5MHz. If the
> maximum bandwidth allowed by the channel is smaller than 5MHz,
> the channel is disabled. Otherwise the channel is used and the
> flags are set according to the bandwidth allowed by the channel.
>
> Signed-off-by: Rostislav Lisovy <rostislav.lisovy@fel.cvut.cz>
This change causes a regression and needs to be reverted or fixed.
It leaves Channel 12 enabled for US regdomain and does not prevent
bringing up AP mode on it (IEEE80211_CHAN_NO_20MHZ does not get set).
I think the main problem with this change is that max_bandwidth_khz
(which is used to derive the no-10mhz and no-20mhz flags) does not
consider the frequency when calculating the max bandwidth.
- Felix
next prev parent reply other threads:[~2014-06-22 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 12:37 [PATCH 0/2 v3] cfg80211: The very first steps to support 5/10MHz channels in 5.9Ghz band Rostislav Lisovy
2014-04-15 12:37 ` [PATCH 1/2] cfg80211: Add attributes describing prohibited channel bandwidth Rostislav Lisovy
2014-04-15 12:37 ` [PATCH 2/2] cfg80211: Use 5MHz bandwidth by default when checking usable channels Rostislav Lisovy
2014-06-22 11:41 ` Felix Fietkau [this message]
2014-06-23 9:08 ` Johannes Berg
2014-06-23 10:04 ` Felix Fietkau
2014-06-23 10:05 ` Johannes Berg
2014-06-23 14:38 ` Rostislav Lisovy
2014-06-23 14:46 ` Felix Fietkau
2014-06-23 14:58 ` Rostislav Lisovy
2014-04-25 15:40 ` [PATCH 0/2 v3] cfg80211: The very first steps to support 5/10MHz channels in 5.9Ghz band Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A6C0FF.9090104@openwrt.org \
--to=nbd@openwrt.org \
--cc=jan-niklas.meier@volkswagen.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lisovy@gmail.com \
--cc=rostislav.lisovy@fel.cvut.cz \
--cc=s.sander@nordsys.de \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.