All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Liqin Chen <liqin.linux@gmail.com>,
	Lennox Wu <lennox.wu@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] arch/score/include/asm/uaccess.h: Use standard clear_user() prototype
Date: Sun, 22 Jun 2014 20:29:02 +0800	[thread overview]
Message-ID: <53A6CC0E.5010000@gmail.com> (raw)

Use standard clear_user() just like another architectures, also match
__clear_user() under score.

The related warning (allmodconfig under score):

    CC [M]  drivers/md/dm-ioctl.o
  drivers/md/dm-ioctl.c: In function 'copy_params':
  drivers/md/dm-ioctl.c:1728:33: warning: passing argument 1 of 'clear_user' from incompatible pointer type
     if (secure_data && clear_user(user, param_kernel->data_size))
                                   ^
  In file included from include/linux/uaccess.h:5:0,
                   from include/linux/highmem.h:8,
                   from include/linux/bio.h:23,
                   from include/linux/device-mapper.h:11,
                   from drivers/md/dm.h:14,
                   from drivers/md/dm-ioctl.c:8:
  ./arch/score/include/asm/uaccess.h:364:29: note: expected 'char *' but argument is of type 'struct dm_ioctl *'
   static inline unsigned long clear_user(char *src, unsigned long size)
                               ^

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/score/include/asm/uaccess.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/score/include/asm/uaccess.h b/arch/score/include/asm/uaccess.h
index ab66ddd..259a539 100644
--- a/arch/score/include/asm/uaccess.h
+++ b/arch/score/include/asm/uaccess.h
@@ -361,7 +361,8 @@ copy_in_user(void *to, const void *from, unsigned long len)
  */
 extern unsigned long __clear_user(void __user *src, unsigned long size);
 
-static inline unsigned long clear_user(char *src, unsigned long size)
+static inline unsigned long __must_check clear_user(void __user *src,
+							unsigned long size)
 {
 	if (access_ok(VERIFY_WRITE, src, size))
 		return __clear_user(src, size);
-- 
1.9.2.459.g68773ac

             reply	other threads:[~2014-06-22 12:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-22 12:29 Chen Gang [this message]
2014-06-25 15:29 ` [PATCH] arch/score/include/asm/uaccess.h: Use standard clear_user() prototype Lennox Wu
2014-06-25 22:11   ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A6CC0E.5010000@gmail.com \
    --to=gang.chen.5i5j@gmail.com \
    --cc=lennox.wu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=liqin.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.