All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Brandstatter <icarusthecow@gmail.com>
To: Josef Bacik <jbacik@fb.com>, linux-btrfs@vger.kernel.org
Subject: Re: Removing file = quota exceded
Date: Sun, 22 Jun 2014 12:56:30 -0500	[thread overview]
Message-ID: <53A718CE.9030701@gmail.com> (raw)
In-Reply-To: <53A7069E.5010003@fb.com>

One thing i note is that I can unlink from a full filesystem.
I tested it by writing a file until the device ran out of space, and
then rm it,
the same method that i used to cause the disk quota error, and it was
able to remove without
issue.

-Kevin

On 06/22/2014 11:38 AM, Josef Bacik wrote:
> On 06/21/2014 06:16 PM, Kevin Brandstatter wrote:
>> so ive come accross the issue of being unable to remove a file when a
>> subvolume quota is reached. This can be resolved by truncating the file
>> first, or removing the quota temporarily.
>> However, it should be reasonable that you should alwasy be able to
>> remove a file, regardless of quota limitations yes?
>> Upon delving into the code, I found the comment that an unlink may not
>> always free space. This seems reasonable on a COW filesystem, however,
>> it should not preclude a removal IMO (please correct me if i missed
>> something)
>> Personally I'm looking to try and fix this issue to allow a removal of a
>> file even when the subvol quota has been reached. I'm hoping one of the
>> current developers may be able to assist me in where to focus my
>> efforts, as I am still unable to follow exactly where a remove operation
>> would check the quota limitations.
>> Any help is appreciated.
>>
>
> For quota I think we should always allow unlink, it's not really the
> users fault
> that we sometimes won't actually remove space with unlink.  The normal
> ENOSPC
> stuff still needs to take this into account of course but for quota I
> think it's
> ok to just go over quota.  I'll look into this later this week.  Thanks,
>
> Josef


  reply	other threads:[~2014-06-22 17:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-22  1:16 Removing file = quota exceded Kevin Brandstatter
2014-06-22 16:38 ` Josef Bacik
2014-06-22 17:56   ` Kevin Brandstatter [this message]
2014-06-23  1:53     ` Duncan
2014-06-23 23:36       ` [PATCH] handle start_unlink_transaction the same for an exceded quota , limit as an out of space error Kevin Brandstatter
2014-06-24  5:31       ` Removing file = quota exceded Duncan
2014-06-24 12:15         ` Kevin Brandstatter
2014-06-23 23:43   ` Kevin Brandstatter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A718CE.9030701@gmail.com \
    --to=icarusthecow@gmail.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.