Re: [PATCH] fs/ntfs: Use '%tx' instead of '%zx'

[Chen Gang <gang.chen.5i5j@gmail.com>]

On 06/23/2014 09:46 AM, Joe Perches wrote:
> Please make sure to cc the specific maintainer
> 
> $ ./scripts/get_maintainer.pl -f fs/ntfs/
> Anton Altaparmakov <anton@tuxera.com> (supporter:NTFS FILESYSTEM)
> linux-ntfs-dev@lists.sourceforge.net (open list:NTFS FILESYSTEM)
> linux-kernel@vger.kernel.org (open list)
> 
> (cc'ing Anton)
> 

Yes, I have sent to specific maintainer.


> btw Anton, it seems ntfs_debug does not terminate
> messages with a "\n".  That means that messages
> could be interleaved with other output.
> 
> Maybe this patch as well as Chen Gang's below should be applied
> ---
>  fs/ntfs/debug.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ntfs/debug.c b/fs/ntfs/debug.c
> index dd6103c..1e824f0 100644
> --- a/fs/ntfs/debug.c
> +++ b/fs/ntfs/debug.c
> @@ -126,7 +126,8 @@ void __ntfs_debug (const char *file, int line, const char *function,
>  	va_start(args, fmt);
>  	vaf.fmt = fmt;
>  	vaf.va = &args;
> -	pr_debug("(%s, %d): %s(): %pV", file, line, flen ? function : "", &vaf);
> +	pr_debug("(%s, %d): %s(): %pV\n",
> +		 file, line, flen ? function : "", &vaf);
>  	va_end(args);
>  }
>  

Hmm... at least, the patch above is fine to me.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed