All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] graph-depends.py: support python3
Date: Mon, 23 Jun 2014 07:32:18 +0200	[thread overview]
Message-ID: <53A7BBE2.5050603@mind.be> (raw)
In-Reply-To: <1133175477.273342.1403300186442.JavaMail.root@mail>

On 20/06/14 23:36, Vivien Didelot wrote:
> Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> But there's also support/scripts/graph-build-time and support/scripts/xorg-release.
> There are some calls to the Python executable in docs/manual as well.

 True, but let's take it one step at a time :-)


 Regards,
 Arnout


 BTW, list policy says that you shouldn't top-post. So you would put your
Reviewed-by tag below my Sob, i.e...

> 
> Vivien
> 
> ----- Mail original -----
>> De: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
>> ?: buildroot at buildroot.org
>> Cc: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>, "Vivien Didelot" <vivien.didelot@savoirfairelinux.com>
>> Envoy?: Vendredi 20 Juin 2014 16:34:07
>> Objet: [PATCH] graph-depends.py: support python3
>>
>> This patch is the result of 2to3.
>>
>> In addition, universal_newlines=True is added to the Popen calls. In
>> python3, this makes sure that the output is decoded so that we get a
>> string instead of a buffer object.
>>
>> Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

... here

 Also, for a long mail, remove the irrelevant part of the quotation, e.g. like this:

>> ---
>>  support/scripts/graph-depends | 24 ++++++++++++------------
>>  1 file changed, 12 insertions(+), 12 deletions(-)
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-06-23  5:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 20:34 [Buildroot] [PATCH] graph-depends.py: support python3 Arnout Vandecappelle
2014-06-20 21:36 ` Vivien Didelot
2014-06-23  5:32   ` Arnout Vandecappelle [this message]
2014-06-22 17:05 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A7BBE2.5050603@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.