From: Robert Baldyga <r.baldyga@samsung.com>
To: balbi@ti.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
andrzej.p@samsung.com
Subject: Re: [PATCH] usb: gadget: add claimed field in struct usb_ep
Date: Mon, 23 Jun 2014 08:07:43 +0200 [thread overview]
Message-ID: <53A7C42F.1060603@samsung.com> (raw)
In-Reply-To: <20140619150853.GG23782@saruman.home>
On 06/19/2014 05:08 PM, Felipe Balbi wrote:
> On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Baldyga wrote:
>> This field allows to mark ep as claimed in more clear way. Claiming
>> endpoint by setting driver_data to non-null value is leaky solution
>> and makes code unreadable.
>
> how come ? How can it be unreadable ? how can it be leaky ?
>
What if gadget will not assign any value to driver_data (just like
Gadget Zero do)? Endpoint will be seen as not used, and autoconfig will
return it more than one time. That's what I call leaky solution.
Information if endpoint is claimed or not is its internal state and
should not depend on assigning non-null value to driver_data field.
next prev parent reply other threads:[~2014-06-23 6:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 8:20 [PATCH] usb: gadget: add claimed field in struct usb_ep Robert Baldyga
2014-06-19 15:08 ` Felipe Balbi
2014-06-23 6:07 ` Robert Baldyga [this message]
2014-06-23 18:27 ` Felipe Balbi
2014-06-24 12:16 ` Robert Baldyga
2014-06-30 18:33 ` Felipe Balbi
2014-07-01 6:05 ` Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A7C42F.1060603@samsung.com \
--to=r.baldyga@samsung.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.