From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v3 2/7] ethdev: add autoneg parameter in flow ctrl accessors Date: Mon, 23 Jun 2014 11:26:46 +0200 Message-ID: <53A7F2D6.50803@6wind.com> References: <1403028572-24794-1-git-send-email-david.marchand@6wind.com> <1403028572-24794-3-git-send-email-david.marchand@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D3B9A6@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Liu, Jijiang" Return-path: In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D3B9A6-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hello, On 06/23/2014 05:35 AM, Liu, Jijiang wrote: > There was an error when we used the following test command to test latest master branch for 10G NIC flow control > test command: > ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4-- -i --burst=1 --txpt=32 --txht=8 --txwt=0 --txfreet=0 --rxfreet=64 --mbcache=250 --portmask=f > testpmd> set flow_ctrl rx off tx off 300 50 10 1 mac_ctrl_frame_fwd on 0 > bad flow contrl parameter, return code = -95 > > And the reason is that autoneg check failed in ixgbe_flow_ctrl_set() function. > if (fc_conf->autoneg != !hw->fc.disable_fc_autoneg) > return -ENOTSUP; Ok, indeed, there is a problem with the autoneg field I added. I will try to send a fix, but I am a bit short on time (and I will be offline for a week starting thursday), so if you have a fix before me, feel free to send it. -- David Marchand