Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

[Chen Gang <gang.chen.5i5j@gmail.com>]

On 06/23/2014 05:38 PM, David Rientjes wrote:
> On Sun, 22 Jun 2014, Chen Gang wrote:
> 
>> diff --git a/arch/score/include/uapi/asm/ptrace.h b/arch/score/include/uapi/asm/ptrace.h
>> index f59771a..7a0ead9 100644
>> --- a/arch/score/include/uapi/asm/ptrace.h
>> +++ b/arch/score/include/uapi/asm/ptrace.h
>> @@ -4,16 +4,16 @@
>>  #define PTRACE_GETREGS		12
>>  #define PTRACE_SETREGS		13
>>  
>> -#define PC		32
>> -#define CONDITION	33
>> -#define ECR		34
>> -#define EMA		35
>> -#define CEH		36
>> -#define CEL		37
>> -#define COUNTER		38
>> -#define LDCR		39
>> -#define STCR		40
>> -#define PSR		41
>> +#define SCORE_PC		32
>> +#define SCORE_CONDITION		33
>> +#define SCORE_ECR		34
>> +#define SCORE_EMA		35
>> +#define SCORE_CEH		36
>> +#define SOCRE_CEL		37
> 
> SOCRE?
> 

OH, typo issue, thanks.

>> +#define SCORE_COUNTER		38
>> +#define SCORE_LDCR		39
>> +#define SCORE_STCR		40
>> +#define SCORE_PSR		41
>>  
>>  #define SINGLESTEP16_INSN	0x7006
>>  #define SINGLESTEP32_INSN	0x840C8000
> 
> This is a uapi header file, what was done to ensure this doesn't introduce 
> userspace breakage?
> 

Do you have any new idea for it, since you have question?


For me, one solving way is: use "#if defined(__KERNEL__) &&
defined(__LINUX__)" for check whether need a prefix (e.g. 'SCORE_') for it.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed