From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Fabian Frederick <fabf@skynet.be>, <linux-kernel@vger.kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary test on unsigned value
Date: Mon, 23 Jun 2014 14:35:05 +0300 [thread overview]
Message-ID: <53A810E9.4070707@ti.com> (raw)
In-Reply-To: <1402516440-20554-1-git-send-email-fabf@skynet.be>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On 11/06/14 22:54, Fabian Frederick wrote:
> unsigned value is never < 0
>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/video/fbdev/sis/sis_main.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
> index 22ad028..3f12a2d 100644
> --- a/drivers/video/fbdev/sis/sis_main.c
> +++ b/drivers/video/fbdev/sis/sis_main.c
> @@ -1572,10 +1572,6 @@ sisfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
> /* Adapt RGB settings */
> sisfb_bpp_to_var(ivideo, var);
>
> - /* Sanity check for offsets */
> - if(var->xoffset < 0) var->xoffset = 0;
> - if(var->yoffset < 0) var->yoffset = 0;
> -
> if(var->xres > var->xres_virtual)
> var->xres_virtual = var->xres;
>
>
Thanks, queued for 3.17.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-06-23 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 19:54 [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary test on unsigned value Fabian Frederick
2014-06-23 11:35 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A810E9.4070707@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.