All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [patch] video/mbx: indent some if statements
Date: Mon, 23 Jun 2014 11:51:42 +0000	[thread overview]
Message-ID: <53A814CE.5090708@ti.com> (raw)
In-Reply-To: <20140611064535.GA16443@mwanda>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On 11/06/14 09:45, Dan Carpenter wrote:
> Checkpatch.pl worries that we have left off the conditional bit because
> it isn't indented correctly.
> 
> WARNING: suspect code indent for conditional statements (24, 24)
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c
> index 2bd52ed..698df954 100644
> --- a/drivers/video/fbdev/mbx/mbxfb.c
> +++ b/drivers/video/fbdev/mbx/mbxfb.c
> @@ -628,14 +628,14 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
>  		case MBXFB_IOCS_PLANEORDER:
>  			if (copy_from_user(&porder, (void __user*)arg,
>  					sizeof(struct mbxfb_planeorder)))
> -			return -EFAULT;
> +				return -EFAULT;
>  
>  			return mbxfb_ioctl_planeorder(&porder);
>  
>  		case MBXFB_IOCS_ALPHA:
>  			if (copy_from_user(&alpha, (void __user*)arg,
>  					sizeof(struct mbxfb_alphaCtl)))
> -			return -EFAULT;
> +				return -EFAULT;
>  
>  			return mbxfb_ioctl_alphactl(&alpha);
>  
> 

Thanks, queued for 3.17.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2014-06-23 11:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  6:45 [patch] video/mbx: indent some if statements Dan Carpenter
2014-06-23 11:51 ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A814CE.5090708@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.