From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Stanislav Fomichev <stfomichev@yandex-team.ru>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
jolsa@redhat.com, xiaoguangrong@linux.vnet.ibm.com,
yangds.fnst@cn.fujitsu.com, adrian.hunter@intel.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils
Date: Mon, 23 Jun 2014 08:06:34 -0600 [thread overview]
Message-ID: <53A8346A.80905@gmail.com> (raw)
In-Reply-To: <20140620144427.GF31524@kernel.org>
On 6/20/14, 8:44 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 20, 2014 at 02:49:48PM +0400, Stanislav Fomichev escreveu:
>> It will be reused by perf trace in the following commit.
>
> I know this is needed, but one of the goals when I started builtin-trace
> was not to use perf_session at all, as it initially was just about the
> live mode.
>
> record/replay came later and ended up needing it,
perf-kvm does not use the session code because I kept tripping over the
out of order timestamp problem. By limiting the number of events read in
a single pass I was able to smooth out the load and avoided hitting it
as often. As I mentioned before the final piece was using the perf_clock
timestamp at the start of the round to ensure I never hit it.
Stanislav: are you seeing out of order timestamp errors or just trying
to reuse the live code from perf-kvm?
David
next prev parent reply other threads:[~2014-06-23 14:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 10:49 [PATCH v2 0/7] perf trace pagefaults Stanislav Fomichev
2014-06-20 10:49 ` [PATCH 1/7] perf trace: add perf_event parameter to tracepoint_handler Stanislav Fomichev
2014-06-20 10:49 ` [PATCH 2/7] perf trace: add support for pagefault tracing Stanislav Fomichev
2014-06-20 14:59 ` Arnaldo Carvalho de Melo
2014-06-20 15:49 ` Stanislav Fomichev
2014-06-20 16:11 ` Arnaldo Carvalho de Melo
2014-06-24 12:46 ` Stanislav Fomichev
2014-06-24 15:21 ` Arnaldo Carvalho de Melo
2014-06-20 10:49 ` [PATCH 3/7] perf trace: add pagefaults record and replay support Stanislav Fomichev
2014-06-20 10:49 ` [PATCH 4/7] perf trace: add pagefault statistics Stanislav Fomichev
2014-06-20 10:49 ` [PATCH 5/7] perf trace: add possibility to switch off syscall events Stanislav Fomichev
2014-06-20 10:49 ` [PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils Stanislav Fomichev
2014-06-20 14:44 ` Arnaldo Carvalho de Melo
2014-06-20 15:07 ` Stanislav Fomichev
2014-06-20 15:25 ` Arnaldo Carvalho de Melo
2014-06-23 14:06 ` David Ahern [this message]
2014-06-23 14:14 ` Stanislav Fomichev
2014-06-20 10:49 ` [PATCH 7/7] perf trace: add events cache Stanislav Fomichev
2014-06-20 13:21 ` [PATCH v2 0/7] perf trace pagefaults Arnaldo Carvalho de Melo
2014-06-20 15:03 ` Stanislav Fomichev
2014-06-20 15:24 ` Arnaldo Carvalho de Melo
2014-06-20 16:18 ` Stanislav Fomichev
2014-06-20 18:30 ` Arnaldo Carvalho de Melo
2014-06-23 11:41 ` Stanislav Fomichev
2014-06-24 14:15 ` Arnaldo Carvalho de Melo
2014-06-23 14:00 ` David Ahern
2014-06-24 7:17 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A8346A.80905@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=stfomichev@yandex-team.ru \
--cc=xiaoguangrong@linux.vnet.ibm.com \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.