From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz6bK-0008Rw-Ah for qemu-devel@nongnu.org; Mon, 23 Jun 2014 11:56:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz6bD-0002gk-46 for qemu-devel@nongnu.org; Mon, 23 Jun 2014 11:56:10 -0400 Received: from mail-qc0-x230.google.com ([2607:f8b0:400d:c01::230]:35416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz6bC-0002gg-Vf for qemu-devel@nongnu.org; Mon, 23 Jun 2014 11:56:03 -0400 Received: by mail-qc0-f176.google.com with SMTP id w7so6153193qcr.7 for ; Mon, 23 Jun 2014 08:56:02 -0700 (PDT) Sender: Richard Henderson Message-ID: <53A84E0E.8070505@twiddle.net> Date: Mon, 23 Jun 2014 08:55:58 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1403535303-14939-1-git-send-email-peter.maydell@linaro.org> <53A84184.6090000@redhat.com> In-Reply-To: <53A84184.6090000@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] coroutine-win32.c: Add noinline attribute to work around gcc bug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Peter Maydell , qemu-devel@nongnu.org Cc: Stefan Weil , patches@linaro.org On 06/23/2014 08:02 AM, Paolo Bonzini wrote: > * I would apply the workaround on all backends, just to be safe. I guess the > block maintainers can do that. The other backends don't use TLS, they use pthread_getspecific, which is a normal function call that gcc will not hoist out of the loop. Therefore the other backends do not suffer from the same problem. It's also Reviewed-by: Richard Henderson r~