From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH RFC OSSTEST 6/9] Toolstack: Refactor guest lifecycle. Date: Mon, 23 Jun 2014 15:01:05 -0600 Message-ID: <53A89591.2060801@suse.com> References: <1403018758.25074.5.camel@kazak.uk.xensource.com> <1403018809-25509-6-git-send-email-ian.campbell@citrix.com> <1403023514.16864.210.camel@Solace> <1403024199.25771.40.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1403024199.25771.40.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Dario Faggioli , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Ian Campbell wrote: > On Tue, 2014-06-17 at 18:45 +0200, Dario Faggioli wrote: > >> On mar, 2014-06-17 at 16:26 +0100, Ian Campbell wrote: >> >>> Implement destory/create as per toolstack methods, including implementing the >>> libvirt version which previously didn't work. To do this we use the virsh >>> capability to convert an xl/xm style config file into the correct XML. >>> >>> xend basically calls into the xl helper since they are compatible. >>> >>> Signed-off-by: Ian Campbell >>> --- >>> >>> +sub create ($$) { >>> + my ($self,$cfg) = @_; >>> + my $ho = $self->{Host}; >>> + my $lcfg = $cfg; >>> + $lcfg =~ s,/,-,g; >>> + $lcfg = "$ho->{Name}--$lcfg"; >>> + target_cmd_root($ho, "virsh domxml-from-native xen-xm $cfg > $cfg.xml", 30); >>> + target_getfile_root($ho,60,"$cfg.xml", "$stash/$lcfg"); >>> + target_cmd_root($ho, "virsh create --file $cfg.xml", 100); >>> +} >>> + >>> >> I agree that domxml-from-native would be the best thing to do here. >> >> However, we need to double check how well it works, and probably commit >> to improve that, as, last time I checked, it was doing a pretty poor >> job. :-( >> >> Jim, what's the status of that thing? >> > > It worked well enough for osstest to start a guest with its usual > config, with the libvirt bugfix I sent out a few hours ago. > I'm not aware of any issues with the xen-xm conversion, but then again haven't tested all possible configs. Ian found one such untested config (root=) just last week. Conversion of xl config is another matter. Currently, libvirt doesn't support 'virsh domxml-{from,to}-native xen-xl ...'. David Kiarie is going to look at this as part of his GSoC work on the libvirt libxl driver. > But the whole point of the tests is to find bugs, so I don't see the > fact that this may or may not be buggy as a reason for osstest not to > use it. If that shows that it is buggy then we should fix it. > Agreed. Regards, Jim