From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-trivial] [PATCH] target-s390x: Remove unused ld_code6() function
Date: Mon, 23 Jun 2014 21:17:20 -0700 [thread overview]
Message-ID: <53A8FBD0.601@twiddle.net> (raw)
In-Reply-To: <1403564794-15881-1-git-send-email-peter.maydell@linaro.org>
On 06/23/2014 04:06 PM, Peter Maydell wrote:
> The ld_code6() function is unused; remove it.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> We could use this for loads of 6-byte insns, but that would
> imply a pointless reload of the first 2 bytes, which is
> presumably why this function isn't actually used.
Exactly so.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] target-s390x: Remove unused ld_code6() function
Date: Mon, 23 Jun 2014 21:17:20 -0700 [thread overview]
Message-ID: <53A8FBD0.601@twiddle.net> (raw)
In-Reply-To: <1403564794-15881-1-git-send-email-peter.maydell@linaro.org>
On 06/23/2014 04:06 PM, Peter Maydell wrote:
> The ld_code6() function is unused; remove it.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> We could use this for loads of 6-byte insns, but that would
> imply a pointless reload of the first 2 bytes, which is
> presumably why this function isn't actually used.
Exactly so.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2014-06-24 4:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 23:06 [Qemu-trivial] [PATCH] target-s390x: Remove unused ld_code6() function Peter Maydell
2014-06-23 23:06 ` [Qemu-devel] " Peter Maydell
2014-06-24 4:17 ` Richard Henderson [this message]
2014-06-24 4:17 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A8FBD0.601@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.