All of lore.kernel.org
 help / color / mirror / Atom feed
From: slapdau@yahoo.com.au (Craig McGeachie)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/3] Enable BCM2835 mailbox support
Date: Tue, 24 Jun 2014 18:21:24 +1200	[thread overview]
Message-ID: <53A918E4.4080707@yahoo.com.au> (raw)
In-Reply-To: <1403433943.532.1.camel@goatlord.localdomain>

On 22/06/14 22:45, Lubomir Rintel wrote:
> Hi Craig,
> As the work on common mailbox framework progressed, I've updated the
> driver to work with v7 of it (I've also ported the cpufreq and vchiq
> drivers, which I'd like to post once the mailbox framework and your
> drivers are in):
>
> https://github.com/hackerspace/rpi-linux/commits/lr-vchiq-new-mailbox
>
> I'm not sending inline patches for review, since neither the framework
> nor your your mbox and thermal drivers are in yet, but I'm wondering if
> you could take a look and eventually fold the changes back into your
> drivers? (I've kept them in separate commits in my tree, so that it's
> easy for you to keep track of the changes).

It's been 9 months since I last looked at this.  I've been watching the 
work on the mailbox framework, with considerable interest, over the last 
week, but have not actively done anything with it.

I have a few other projects at the moment, and given that I only do this 
in my spare time in the evenings, it will take several days to get back 
into it.  But I will make an effort to import, build, and try them out. 
In the meantime I've had a brief look at the changes that you made and 
can see nothing wrong with any of them.  The "useless gotoes" were 
embarrassing.

Although I can pull your changes back into my tree, I don't feel that 
this will be helpful in getting them accepted into the mainline. But I'm 
happy enough to format a patch and submit it somewhere, at some point.

Cheers,
Craig.

      reply	other threads:[~2014-06-24  6:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13 11:32 [RFC PATCH 2/3] Enable BCM2835 mailbox support Craig McGeachie
2013-10-02  3:05 ` Stephen Warren
2013-10-02  9:52   ` Craig McGeachie
2013-10-03  7:30     ` Craig McGeachie
2014-06-22 10:45 ` Lubomir Rintel
2014-06-24  6:21   ` Craig McGeachie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A918E4.4080707@yahoo.com.au \
    --to=slapdau@yahoo.com.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.