Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes

[Alexander Sverdlin <alexander.sverdlin@nsn.com>]

Hi!

On 24/06/14 10:19, ext Pantelis Antoniou wrote:

[...]

>> No, it's not bool... It's an existence of a void property. 
>>
> 
> The is no such thing as a void property. A property without contents is defined as a bool. 
> 
>>>From Documentation/devicetree/bindings/interrupts.txt
> 
> "A device is marked as an interrupt controller with the "interrupt-controller"
> property. This is a empty, boolean property."

Maybe, the comment here should be also corrected :)

If we refer back to ePAPR, there are several use-cases of "<empty>" properties, for example:

2.3.8 ranges
Property: ranges
Value type: <empty> or <prop-encoded-array> encoded as arbitrary number of triplets of (child-bus-
address, parent-bus-address, length).
Description:
The ranges property provides a means of defining a mapping or translation between the
address space of the bus (the child address space) and the address space of the bus node's
parent (the parent address space).
...
If the property is defined with an <empty> value, it specifies that the parent and child address
space is identical, and no address translation is required.

=> by no means, should <empty> here be considered a "boolean".

2.4.2.2 Interrupt-controller
Property: interrupt-controller
Value type: <empty>
Description:
The presence of an interrupt-controller property defines a node as an interrupt controller node.

Also, ePAPR has no single occurrence of "bool", so this is something out of specification scope of the
device-tree :)

>>> The use of of_get_property is a bug here. It is perfectly valid for a property to have a
>>> NULL value when length = 0.
>>
>> of_find_property() would be really correct in this particular case...

-- 
Best regards,
Alexander Sverdlin.