From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [Gitorious] Activity: prabhakar requested a merge of prab... Date: Tue, 24 Jun 2014 13:11:03 +0200 Message-ID: <53A95CC7.5000008@pengutronix.de> References: <53a829dc98811_78d23ff48250bea851769@ratt.gitorious.c.bitbit.net.mail> <53A851DC.2060801@hartkopp.net> <53A85445.8070400@pengutronix.de> <53A8560F.4060607@hartkopp.net> <53A859E5.7050107@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Vsi4xE7vHNq77kvVD1GmCDW7oGBMXRMnO" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:58141 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbaFXLLP (ORCPT ); Tue, 24 Jun 2014 07:11:15 -0400 In-Reply-To: Sender: linux-can-owner@vger.kernel.org List-ID: To: Prabhakar Lad Cc: Oliver Hartkopp , "linux-can@vger.kernel.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Vsi4xE7vHNq77kvVD1GmCDW7oGBMXRMnO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/24/2014 01:06 PM, Prabhakar Lad wrote: > Hi >=20 > On Mon, Jun 23, 2014 at 5:46 PM, Marc Kleine-Budde = wrote: >> On 06/23/2014 06:30 PM, Oliver Hartkopp wrote: >>> On 23.06.2014 18:22, Marc Kleine-Budde wrote: >>>> On 06/23/2014 06:12 PM, Oliver Hartkopp wrote: >>>>> Hi Prabhakar, >>>>> >>>>> thanks for your patch. >>>>> >>>>> Can you please send it with git send-email to the mailing list for = a review? >>>>> >>>>> Additionally: >>>>> >>>>> Does this patch introduce any backward compatibility restrictions (= e.g. you >>>>> need at least the includes from 2.6.14+ to build candump ...). >>>> >>>> When was CAN support added to the linux kernel? :) >>> >>> I know that you would detect this joke ;-) >>> Btw. I backported SocketCAN to 2.6.13 - so my question is not totally= >>> brain-damaged when talking about the can-utils which are not sticking= to a >>> specific kernel version. >> >> I was assuming that there was a certain seriousness in your statement = :D >> >> Do you mean the inclusion of "sched.h"? I think this comes from the >> glibc. However, we can add autotool support to detect this. >> >>>>> You only provide to configure a value for SCHED_RR. >>>>> Does it make sense to provide other scheduling policies too? >>>> >>>> I would use chrt to start the tool, if I need non standard schedulin= g >>>> policies. >>> >>> But then you would like to specifiy the scheduling policy?? >> >> You can use chrt to start another program with different scheduling >> policies, it's like nice, but with more functionality. See man page of= >> chrt for more information. >> > What do you suggest to go with the patch or just use chrt ? =46rom my point of view candump is a debugging tool anyways, using it together with chrt makes sense. Do you have a good argument why not to use chrt? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --Vsi4xE7vHNq77kvVD1GmCDW7oGBMXRMnO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlOpXMsACgkQjTAFq1RaXHPnsQCfS0N+nilaCP/ZEidpjCch+Oo5 BqMAniAXC1r+pW6Frjyu4gEn5baSqIH8 =DtGW -----END PGP SIGNATURE----- --Vsi4xE7vHNq77kvVD1GmCDW7oGBMXRMnO--