From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzQPB-0005kP-Cz for qemu-devel@nongnu.org; Tue, 24 Jun 2014 09:05:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzQP3-0000s3-H6 for qemu-devel@nongnu.org; Tue, 24 Jun 2014 09:04:57 -0400 Message-ID: <53A9776D.9070303@suse.de> Date: Tue, 24 Jun 2014 15:04:45 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1403611807-7082-1-git-send-email-Bharat.Bhushan@freescale.com> <1403611807-7082-5-git-send-email-Bharat.Bhushan@freescale.com> In-Reply-To: <1403611807-7082-5-git-send-email-Bharat.Bhushan@freescale.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5 v3][RESEND] ppc: Add software breakpoint support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharat Bhushan Cc: maddy@linux.vnet.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 24.06.14 14:10, Bharat Bhushan wrote: > This patch allow insert/remove software breakpoint > > Signed-off-by: Bharat Bhushan > --- > target-ppc/kvm.c | 71 +++++++++++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 57 insertions(+), 14 deletions(-) > > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index 5238de7..8e2dbb3 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -1317,6 +1317,53 @@ static int kvmppc_handle_dcr_write(CPUPPCState *env, uint32_t dcrn, uint32_t dat > return 0; > } > > +int kvm_arch_insert_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp) > +{ > + /* Mixed endian case is not handled */ > + uint32_t sc = debug_inst_opcode; What if debug_inst_opcode has never been set (thus is 0)? In that case we should fail the insert, no? Alex