From: David Vrabel <david.vrabel@citrix.com>
To: Julien Grall <julien.grall@linaro.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com,
tim@xen.org, Jan Beulich <jbeulich@suse.com>,
Aravindh Puthiyaparambil <aravindp@cisco.com>
Subject: Re: [PATCH] libxc: Fix xc_mem_event.c compilation for ARM
Date: Tue, 24 Jun 2014 15:02:25 +0100 [thread overview]
Message-ID: <53A984F1.8020605@citrix.com> (raw)
In-Reply-To: <53A98149.6000208@linaro.org>
On 24/06/14 14:46, Julien Grall wrote:
> On 06/24/2014 02:16 PM, Ian Campbell wrote:
>> On Mon, 2014-06-23 at 16:34 +0100, Ian Jackson wrote:
>> FWIW I think the same issue with HVM parameters would impact 32-bit dom0
>> on x86 too, but I suppose the magic PFNs have the same property there
>> too. Luckily I think David's patches sorts it out at the root.
>
> On IRC, I pointed that the HVM param hypercall structure is using
> uint64_t for the value rather than the helpers in libxc use unsigned long.
>
> Even tho, it's not an issue for the magic PFN right now, a developer may
> want to add a new HVM param which requires a 64 bit value.
>
> Does David's series sort it out this problem?
Yes. It adds new xc_hvm_param_get() and xc_hvm_param_set() functions
that take uint64_t values and changes all callers (in tools/) to use them.
David
next prev parent reply other threads:[~2014-06-24 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 13:27 [PATCH] libxc: Fix xc_mem_event.c compilation for ARM Julien Grall
2014-06-23 15:34 ` Ian Jackson
2014-06-24 13:16 ` Ian Campbell
2014-06-24 13:46 ` Julien Grall
2014-06-24 14:02 ` David Vrabel [this message]
2014-06-30 18:25 ` Aravindh Puthiyaparambil (aravindp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A984F1.8020605@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=aravindp@cisco.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.