All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Minchan Kim <minchan@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
	Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/13] mm, compaction: move pageblock checks up from isolate_migratepages_range()
Date: Tue, 24 Jun 2014 17:34:32 +0200	[thread overview]
Message-ID: <53A99A88.1040500@suse.cz> (raw)
In-Reply-To: <20140624045252.GA18289@nhori.bos.redhat.com>

On 06/24/2014 06:52 AM, Naoya Horiguchi wrote:
>> -	low_pfn = isolate_migratepages_range(zone, cc, low_pfn, end_pfn, false);
>> -	if (!low_pfn || cc->contended)
>> -		return ISOLATE_ABORT;
>> +		/* Do not scan within a memory hole */
>> +		if (!pfn_valid(low_pfn))
>> +			continue;
>> +
>> +		page = pfn_to_page(low_pfn);
>
> Can we move (page_zone != zone) check here as isolate_freepages() does?

Duplicate perhaps, not sure about move. Does CMA make sure that all 
pages are in the same zone? Common sense tells me it would be useless 
otherwise, but I haven't checked if we can rely on it.

> Thanks,
> Naoya Horiguchi
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Minchan Kim <minchan@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
	Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/13] mm, compaction: move pageblock checks up from isolate_migratepages_range()
Date: Tue, 24 Jun 2014 17:34:32 +0200	[thread overview]
Message-ID: <53A99A88.1040500@suse.cz> (raw)
In-Reply-To: <20140624045252.GA18289@nhori.bos.redhat.com>

On 06/24/2014 06:52 AM, Naoya Horiguchi wrote:
>> -	low_pfn = isolate_migratepages_range(zone, cc, low_pfn, end_pfn, false);
>> -	if (!low_pfn || cc->contended)
>> -		return ISOLATE_ABORT;
>> +		/* Do not scan within a memory hole */
>> +		if (!pfn_valid(low_pfn))
>> +			continue;
>> +
>> +		page = pfn_to_page(low_pfn);
>
> Can we move (page_zone != zone) check here as isolate_freepages() does?

Duplicate perhaps, not sure about move. Does CMA make sure that all 
pages are in the same zone? Common sense tells me it would be useless 
otherwise, but I haven't checked if we can rely on it.

> Thanks,
> Naoya Horiguchi
>


  reply	other threads:[~2014-06-24 15:34 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 15:49 [PATCH v3 00/13] compaction: balancing overhead and success rates Vlastimil Babka
2014-06-20 15:49 ` Vlastimil Babka
2014-06-20 15:49 ` [PATCH v3 01/13] mm, THP: don't hold mmap_sem in khugepaged when allocating THP Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-20 17:45   ` Kirill A. Shutemov
2014-06-20 17:45     ` Kirill A. Shutemov
2014-06-23  5:39     ` Zhang Yanfei
2014-06-23  5:39       ` Zhang Yanfei
2014-06-23  9:52       ` Vlastimil Babka
2014-06-23  9:52         ` Vlastimil Babka
2014-06-23 10:40         ` Zhang Yanfei
2014-06-23 10:40           ` Zhang Yanfei
2014-06-20 15:49 ` [PATCH v3 02/13] mm, compaction: defer each zone individually instead of preferred zone Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-23  2:24   ` Minchan Kim
2014-06-23  2:24     ` Minchan Kim
2014-06-23  6:26   ` Zhang Yanfei
2014-06-23  6:26     ` Zhang Yanfei
2014-06-24  8:23   ` Joonsoo Kim
2014-06-24  8:23     ` Joonsoo Kim
2014-06-24 15:29     ` Vlastimil Babka
2014-06-24 15:29       ` Vlastimil Babka
2014-06-25  1:02       ` Joonsoo Kim
2014-06-25  1:02         ` Joonsoo Kim
2014-06-20 15:49 ` [PATCH v3 03/13] mm, compaction: do not recheck suitable_migration_target under lock Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-20 15:49 ` [PATCH v3 04/13] mm, compaction: move pageblock checks up from isolate_migratepages_range() Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-23  6:57   ` Zhang Yanfei
2014-06-23  6:57     ` Zhang Yanfei
2014-06-24  4:52   ` Naoya Horiguchi
2014-06-24  4:52     ` Naoya Horiguchi
2014-06-24 15:34     ` Vlastimil Babka [this message]
2014-06-24 15:34       ` Vlastimil Babka
2014-06-24 16:58       ` Naoya Horiguchi
2014-06-24 16:58         ` Naoya Horiguchi
2014-06-25  8:50         ` Vlastimil Babka
2014-06-25  8:50           ` Vlastimil Babka
2014-06-25 15:46           ` Naoya Horiguchi
2014-06-25 15:46             ` Naoya Horiguchi
2014-06-24  8:33   ` Joonsoo Kim
2014-06-24  8:33     ` Joonsoo Kim
2014-06-24 15:42     ` Vlastimil Babka
2014-06-24 15:42       ` Vlastimil Babka
2014-06-25  0:53       ` Joonsoo Kim
2014-06-25  0:53         ` Joonsoo Kim
2014-06-25  8:59         ` Vlastimil Babka
2014-06-25  8:59           ` Vlastimil Babka
2014-06-27  5:57           ` Joonsoo Kim
2014-06-27  5:57             ` Joonsoo Kim
2014-06-20 15:49 ` [PATCH v3 05/13] mm, compaction: report compaction as contended only due to lock contention Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-23  1:39   ` Minchan Kim
2014-06-23  1:39     ` Minchan Kim
2014-06-23  8:55     ` Zhang Yanfei
2014-06-23  8:55       ` Zhang Yanfei
2014-06-23 23:35       ` Minchan Kim
2014-06-23 23:35         ` Minchan Kim
2014-06-24  1:07         ` Zhang Yanfei
2014-06-24  1:07           ` Zhang Yanfei
2014-07-11  8:28     ` Vlastimil Babka
2014-07-11  8:28       ` Vlastimil Babka
2014-07-11  9:38       ` Vlastimil Babka
2014-07-11  9:38         ` Vlastimil Babka
2014-06-20 15:49 ` [PATCH v3 06/13] mm, compaction: periodically drop lock and restore IRQs in scanners Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-23  2:53   ` Minchan Kim
2014-06-23  2:53     ` Minchan Kim
2014-07-11 12:03     ` Vlastimil Babka
2014-07-11 12:03       ` Vlastimil Babka
2014-06-23  9:13   ` Zhang Yanfei
2014-06-23  9:13     ` Zhang Yanfei
2014-06-24 15:39   ` Naoya Horiguchi
2014-06-24 15:39     ` Naoya Horiguchi
2014-06-24 15:44     ` Vlastimil Babka
2014-06-24 15:44       ` Vlastimil Babka
2014-06-20 15:49 ` [PATCH v3 07/13] mm, compaction: skip rechecks when lock was already held Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-23  9:16   ` Zhang Yanfei
2014-06-23  9:16     ` Zhang Yanfei
2014-06-24 18:55   ` Naoya Horiguchi
2014-06-24 18:55     ` Naoya Horiguchi
2014-06-20 15:49 ` [PATCH v3 08/13] mm, compaction: remember position within pageblock in free pages scanner Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-23  3:04   ` Minchan Kim
2014-06-23  3:04     ` Minchan Kim
2014-06-23  9:17   ` Zhang Yanfei
2014-06-23  9:17     ` Zhang Yanfei
2014-06-24 19:09   ` Naoya Horiguchi
2014-06-24 19:09     ` Naoya Horiguchi
2014-06-20 15:49 ` [PATCH v3 09/13] mm, compaction: skip buddy pages by their order in the migrate scanner Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-23  3:05   ` Minchan Kim
2014-06-23  3:05     ` Minchan Kim
2014-06-23  9:29   ` Zhang Yanfei
2014-06-23  9:29     ` Zhang Yanfei
2014-06-20 15:49 ` [PATCH v3 10/13] mm: rename allocflags_to_migratetype for clarity Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-24 20:34   ` Naoya Horiguchi
2014-06-24 20:34     ` Naoya Horiguchi
2014-06-20 15:49 ` [PATCH v3 11/13] mm, compaction: pass gfp mask to compact_control Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-23  3:06   ` Minchan Kim
2014-06-23  3:06     ` Minchan Kim
2014-06-23  9:31   ` Zhang Yanfei
2014-06-23  9:31     ` Zhang Yanfei
2014-06-20 15:49 ` [PATCH v3 12/13] mm, compaction: try to capture the just-created high-order freepage Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka
2014-06-25  1:57   ` Naoya Horiguchi
2014-06-25  1:57     ` Naoya Horiguchi
2014-06-25  8:57     ` Vlastimil Babka
2014-06-25  8:57       ` Vlastimil Babka
2014-06-20 15:49 ` [RFC PATCH v3 13/13] mm, compaction: do not migrate pages when that cannot satisfy page fault allocation Vlastimil Babka
2014-06-20 15:49   ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A99A88.1040500@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.