From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50992)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1WzTEx-0002G4-Tp
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 12:06:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1WzTEp-0003gN-KE
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 12:06:35 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:32897)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1WzTEp-0003g7-Cy
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 12:06:27 -0400
Message-ID: <53A9A202.3010004@msgid.tls.msk.ru>
Date: Tue, 24 Jun 2014 20:06:26 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1403183756-24664-1-git-send-email-serge.fdrv@gmail.com>
In-Reply-To: <1403183756-24664-1-git-send-email-serge.fdrv@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: put gprof config in host config
	file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <serge.fdrv@gmail.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Richard Henderson <rth@twiddle.net>

19.06.2014 17:15, Sergey Fedorov wrote:
> The only use for GPROF_CFLAGS is in main makefile, but this variable put
> only to taget config file which is not included to the main makefile.
> Lets put gprof config variables to host config file.

I'm not sure I follow.

First of all, GPROF_CFLAGS is referenced in Makefile.objs, not the
main makefile.  And Makefile.objs _is_ included by the main Makefile.

Second, now you're including this variable into 2 places.

Maybe it is better to stop putting it to the target config file
at the same time?

What problem you're trying to solve?

Maybe some more details will help?

Thanks,

/mjt

> 
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> ---
>  configure | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index dfbe75e..e0433b9 100755
> --- a/configure
> +++ b/configure
> @@ -4323,6 +4323,10 @@ fi
>  if test "$profiler" = "yes" ; then
>    echo "CONFIG_PROFILER=y" >> $config_host_mak
>  fi
> +if test "$gprof" = "yes" ; then
> +  echo "CONFIG_GPROF=y" >> $config_host_mak
> +  echo "GPROF_CFLAGS=-p" >> $config_host_mak
> +fi
>  if test "$slirp" = "yes" ; then
>    echo "CONFIG_SLIRP=y" >> $config_host_mak
>    echo "CONFIG_SMBD_COMMAND=\"$smbd\"" >> $config_host_mak
> @@ -5160,7 +5164,7 @@ alpha)
>  esac
>  
>  if test "$gprof" = "yes" ; then
> -  echo "TARGET_GPROF=yes" >> $config_target_mak
> +  echo "TARGET_GPROF=y" >> $config_target_mak
>    if test "$target_linux_user" = "yes" ; then
>      cflags="-p $cflags"
>      ldflags="-p $ldflags"
>