From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH v2] cansniffer: totally untested hack to reduce display
 update by factor of 10
Date: Tue, 24 Jun 2014 19:51:42 +0200
Message-ID: <53A9BAAE.2000101@hartkopp.net>
References: <1403627167-28287-1-git-send-email-mkl@pengutronix.de> <53A9A96E.5030407@hartkopp.net> <d65e3040-e640-4c05-baa3-d97ce7a448b6@email.android.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <linux-can-owner@vger.kernel.org>
Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]:29319 "EHLO
	mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753521AbaFXRvp (ORCPT
	<rfc822;linux-can@vger.kernel.org>); Tue, 24 Jun 2014 13:51:45 -0400
In-Reply-To: <d65e3040-e640-4c05-baa3-d97ce7a448b6@email.android.com>
Sender: linux-can-owner@vger.kernel.org
List-ID: <linux-can.vger.kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>, felix.seitz@thm-motorsport.de
Cc: linux-can@vger.kernel.org

Ok, it IS faster (and will therefore help Felix).

But the tiny animation is broken now.

I probably have to rework the animation - will send an updated patch.

Thanks for your support,
Oliver

On 24.06.2014 18:44, Marc Kleine-Budde wrote:
> 
> 
> On 24 June 2014 18:38:06 CEST, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>> I'll check it and give a feedback.
>>
>> Btw. it needs a v3:
>>
>>>  /* time defaults */
>>>  
>>> -#define TIMEOUT 50 /* in 100ms */
>>> -#define HOLD    10 /* in 100ms */
>>> -#define LOOP     2 /* in 100ms */
>>> +#define TIMEOUT 500 /* in 10ms */
>>> +#define HOLD    100 /* in 10ms */
>>> +#define LOOP      2 /* in 10ms */
>>
>> LOOP has to be *10 too.
> 
> Yes, if we want unchanged behaviour, which would be better for mainlining. With my patch the default is now 20ms. 
> 
> Marc
>