From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [PATCH] mm: update the description for madvise_remove Date: Tue, 24 Jun 2014 15:44:33 -0700 (PDT) Message-ID: References: <53A9116B.9030004@gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <53A9116B.9030004@gmail.com> Sender: owner-linux-mm@kvack.org To: Wang Sheng-Hui , Michael Kerrisk Cc: Andrew Morton , Naoya Horiguchi , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org List-Id: linux-api@vger.kernel.org On Tue, 24 Jun 2014, Wang Sheng-Hui wrote: > > Currently, we have more filesystems supporting fallocate, e.g > ext4/btrfs. Remove the outdated comment for madvise_remove. > > Signed-off-by: Wang Sheng-Hui > --- > mm/madvise.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index a402f8f..0938b30 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma, > /* > * Application wants to free up the pages and associated backing store. > * This is effectively punching a hole into the middle of a file. > - * > - * NOTE: Currently, only shmfs/tmpfs is supported for this operation. > - * Other filesystems return -ENOSYS. > */ > static long madvise_remove(struct vm_area_struct *vma, > struct vm_area_struct **prev, [For those without context: this patch has been merged into the -mm tree.] This reference also exists in the man-page for madvise(2), are you planning on removing it as well? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Sheng-Hui Subject: Re: [PATCH] mm: update the description for madvise_remove Date: Wed, 25 Jun 2014 09:58:45 +0800 Message-ID: <53AA2CD5.6060202@gmail.com> References: <53A9116B.9030004@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Rientjes Cc: Andrew Morton , Naoya Horiguchi , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org Patch to man-page. [PATCH] madvise.2: update the description for MADV_REMOVE Currently we have more filesystems supporting fallcate, e.g ext4/btrfs, which can response to MADV_REMOVE gracefully. And if filesystems don't support fallocate, the return error would be EOPNOTSUPP, instead of ENOSYS. Signed-off-by: Wang Sheng-Hui --- man2/madvise.2 | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/man2/madvise.2 b/man2/madvise.2 index 032ead7..4ce869c 100644 --- a/man2/madvise.2 +++ b/man2/madvise.2 @@ -99,13 +99,9 @@ or zero-fill-on-demand pages for mappings without an underlying file. .TP .BR MADV_REMOVE " (since Linux 2.6.16)" -Free up a given range of pages -and its associated backing store. -Currently, -.\" 2.6.18-rc5 -only shmfs/tmpfs supports this; other filesystems return with the -error -.BR ENOSYS . +Free up a given range of pages and its associated backing store. +Filesystems that don't support fallocate will return error +.BR EOPNOTSUPP. .\" Databases want to use this feature to drop a section of their .\" bufferpool (shared memory segments) - without writing back to .\" disk/swap space. This feature is also useful for supporting --=20 1.8.3.2 On 2014=E5=B9=B406=E6=9C=8825=E6=97=A5 06:44, David Rientjes wrote: > On Tue, 24 Jun 2014, Wang Sheng-Hui wrote: >=20 >> >> Currently, we have more filesystems supporting fallocate, e.g >> ext4/btrfs. Remove the outdated comment for madvise_remove. >> >> Signed-off-by: Wang Sheng-Hui >> --- >> mm/madvise.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/mm/madvise.c b/mm/madvise.c >> index a402f8f..0938b30 100644 >> --- a/mm/madvise.c >> +++ b/mm/madvise.c >> @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_stru= ct *vma, >> /* >> * Application wants to free up the pages and associated backing st= ore. >> * This is effectively punching a hole into the middle of a file. >> - * >> - * NOTE: Currently, only shmfs/tmpfs is supported for this operatio= n. >> - * Other filesystems return -ENOSYS. >> */ >> static long madvise_remove(struct vm_area_struct *vma, >> struct vm_area_struct **prev, >=20 > [For those without context: this patch has been merged into the -mm t= ree.] >=20 > This reference also exists in the man-page for madvise(2), are you=20 > planning on removing it as well? >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [PATCH] mm: update the description for madvise_remove Date: Wed, 25 Jun 2014 15:30:31 -0700 (PDT) Message-ID: References: <53A9116B.9030004@gmail.com> <53AA2CD5.6060202@gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <53AA2CD5.6060202@gmail.com> Sender: owner-linux-mm@kvack.org To: Wang Sheng-Hui Cc: Michael Kerrisk , Andrew Morton , Naoya Horiguchi , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm@kvack.org, linux-api@vger.kernel.org, linux-man@vger.kernel.org List-Id: linux-api@vger.kernel.org On Wed, 25 Jun 2014, Wang Sheng-Hui wrote: > Patch to man-page. > > [PATCH] madvise.2: update the description for MADV_REMOVE > > Currently we have more filesystems supporting fallcate, e.g ext4/btrfs, > which can response to MADV_REMOVE gracefully. > > And if filesystems don't support fallocate, the return error would be > EOPNOTSUPP, instead of ENOSYS. > > Signed-off-by: Wang Sheng-Hui Great, thanks! This looks like it can be applied immediately and doesn't require us to wait for any kernel change. Good catch with the return value. > --- > man2/madvise.2 | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/man2/madvise.2 b/man2/madvise.2 > index 032ead7..4ce869c 100644 > --- a/man2/madvise.2 > +++ b/man2/madvise.2 > @@ -99,13 +99,9 @@ or zero-fill-on-demand pages for mappings > without an underlying file. > .TP > .BR MADV_REMOVE " (since Linux 2.6.16)" > -Free up a given range of pages > -and its associated backing store. > -Currently, > -.\" 2.6.18-rc5 > -only shmfs/tmpfs supports this; other filesystems return with the > -error > -.BR ENOSYS . > +Free up a given range of pages and its associated backing store. > +Filesystems that don't support fallocate will return error > +.BR EOPNOTSUPP. > .\" Databases want to use this feature to drop a section of their > .\" bufferpool (shared memory segments) - without writing back to > .\" disk/swap space. This feature is also useful for supporting -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f45.google.com (mail-pb0-f45.google.com [209.85.160.45]) by kanga.kvack.org (Postfix) with ESMTP id 35FF96B0031 for ; Tue, 24 Jun 2014 01:50:25 -0400 (EDT) Received: by mail-pb0-f45.google.com with SMTP id rr13so6777746pbb.4 for ; Mon, 23 Jun 2014 22:50:24 -0700 (PDT) Received: from mail-pa0-x229.google.com (mail-pa0-x229.google.com [2607:f8b0:400e:c03::229]) by mx.google.com with ESMTPS id qm6si24827914pac.8.2014.06.23.22.50.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Jun 2014 22:50:24 -0700 (PDT) Received: by mail-pa0-f41.google.com with SMTP id fb1so6832453pad.0 for ; Mon, 23 Jun 2014 22:50:23 -0700 (PDT) Message-ID: <53A9116B.9030004@gmail.com> Date: Tue, 24 Jun 2014 13:49:31 +0800 From: Wang Sheng-Hui MIME-Version: 1.0 Subject: [PATCH] mm: update the description for madvise_remove Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , Naoya Horiguchi , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Currently, we have more filesystems supporting fallocate, e.g ext4/btrfs. Remove the outdated comment for madvise_remove. Signed-off-by: Wang Sheng-Hui --- mm/madvise.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index a402f8f..0938b30 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma, /* * Application wants to free up the pages and associated backing store. * This is effectively punching a hole into the middle of a file. - * - * NOTE: Currently, only shmfs/tmpfs is supported for this operation. - * Other filesystems return -ENOSYS. */ static long madvise_remove(struct vm_area_struct *vma, struct vm_area_struct **prev, -- 1.8.3.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by kanga.kvack.org (Postfix) with ESMTP id 93B206B0031 for ; Tue, 24 Jun 2014 02:02:39 -0400 (EDT) Received: by mail-we0-f182.google.com with SMTP id q59so8202433wes.27 for ; Mon, 23 Jun 2014 23:02:39 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id c9si14822499wix.3.2014.06.23.23.02.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jun 2014 23:02:38 -0700 (PDT) Date: Tue, 24 Jun 2014 01:59:50 -0400 From: Naoya Horiguchi Subject: Re: [PATCH] mm: update the description for madvise_remove Message-ID: <20140624055950.GA12855@nhori.redhat.com> References: <53A9116B.9030004@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53A9116B.9030004@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Wang Sheng-Hui Cc: Andrew Morton , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue, Jun 24, 2014 at 01:49:31PM +0800, Wang Sheng-Hui wrote: > > Currently, we have more filesystems supporting fallocate, e.g > ext4/btrfs. Remove the outdated comment for madvise_remove. > > Signed-off-by: Wang Sheng-Hui Looks good to me. Reviewed-by: Naoya Horiguchi > --- > mm/madvise.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index a402f8f..0938b30 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma, > /* > * Application wants to free up the pages and associated backing store. > * This is effectively punching a hole into the middle of a file. > - * > - * NOTE: Currently, only shmfs/tmpfs is supported for this operation. > - * Other filesystems return -ENOSYS. > */ > static long madvise_remove(struct vm_area_struct *vma, > struct vm_area_struct **prev, > -- > 1.8.3.2 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f52.google.com (mail-pb0-f52.google.com [209.85.160.52]) by kanga.kvack.org (Postfix) with ESMTP id 2A3726B0031 for ; Tue, 24 Jun 2014 21:59:15 -0400 (EDT) Received: by mail-pb0-f52.google.com with SMTP id rq2so1002790pbb.39 for ; Tue, 24 Jun 2014 18:59:14 -0700 (PDT) Received: from mail-pb0-x230.google.com (mail-pb0-x230.google.com [2607:f8b0:400e:c01::230]) by mx.google.com with ESMTPS id bg4si2928538pbb.67.2014.06.24.18.59.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 24 Jun 2014 18:59:14 -0700 (PDT) Received: by mail-pb0-f48.google.com with SMTP id rq2so996307pbb.35 for ; Tue, 24 Jun 2014 18:59:13 -0700 (PDT) Message-ID: <53AA2CD5.6060202@gmail.com> Date: Wed, 25 Jun 2014 09:58:45 +0800 From: Wang Sheng-Hui MIME-Version: 1.0 Subject: Re: [PATCH] mm: update the description for madvise_remove References: <53A9116B.9030004@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes , Michael Kerrisk Cc: Andrew Morton , Naoya Horiguchi , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm@kvack.org, linux-api@vger.kernel.org, linux-man@vger.kernel.org Patch to man-page. [PATCH] madvise.2: update the description for MADV_REMOVE Currently we have more filesystems supporting fallcate, e.g ext4/btrfs, which can response to MADV_REMOVE gracefully. And if filesystems don't support fallocate, the return error would be EOPNOTSUPP, instead of ENOSYS. Signed-off-by: Wang Sheng-Hui --- man2/madvise.2 | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/man2/madvise.2 b/man2/madvise.2 index 032ead7..4ce869c 100644 --- a/man2/madvise.2 +++ b/man2/madvise.2 @@ -99,13 +99,9 @@ or zero-fill-on-demand pages for mappings without an underlying file. .TP .BR MADV_REMOVE " (since Linux 2.6.16)" -Free up a given range of pages -and its associated backing store. -Currently, -.\" 2.6.18-rc5 -only shmfs/tmpfs supports this; other filesystems return with the -error -.BR ENOSYS . +Free up a given range of pages and its associated backing store. +Filesystems that don't support fallocate will return error +.BR EOPNOTSUPP. .\" Databases want to use this feature to drop a section of their .\" bufferpool (shared memory segments) - without writing back to .\" disk/swap space. This feature is also useful for supporting -- 1.8.3.2 On 2014a1'06ae??25ae?JPY 06:44, David Rientjes wrote: > On Tue, 24 Jun 2014, Wang Sheng-Hui wrote: > >> >> Currently, we have more filesystems supporting fallocate, e.g >> ext4/btrfs. Remove the outdated comment for madvise_remove. >> >> Signed-off-by: Wang Sheng-Hui >> --- >> mm/madvise.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/mm/madvise.c b/mm/madvise.c >> index a402f8f..0938b30 100644 >> --- a/mm/madvise.c >> +++ b/mm/madvise.c >> @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma, >> /* >> * Application wants to free up the pages and associated backing store. >> * This is effectively punching a hole into the middle of a file. >> - * >> - * NOTE: Currently, only shmfs/tmpfs is supported for this operation. >> - * Other filesystems return -ENOSYS. >> */ >> static long madvise_remove(struct vm_area_struct *vma, >> struct vm_area_struct **prev, > > [For those without context: this patch has been merged into the -mm tree.] > > This reference also exists in the man-page for madvise(2), are you > planning on removing it as well? > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998AbaFXFu3 (ORCPT ); Tue, 24 Jun 2014 01:50:29 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:48238 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbaFXFuY (ORCPT ); Tue, 24 Jun 2014 01:50:24 -0400 Message-ID: <53A9116B.9030004@gmail.com> Date: Tue, 24 Jun 2014 13:49:31 +0800 From: Wang Sheng-Hui User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Andrew Morton , Naoya Horiguchi , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: update the description for madvise_remove Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, we have more filesystems supporting fallocate, e.g ext4/btrfs. Remove the outdated comment for madvise_remove. Signed-off-by: Wang Sheng-Hui --- mm/madvise.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index a402f8f..0938b30 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma, /* * Application wants to free up the pages and associated backing store. * This is effectively punching a hole into the middle of a file. - * - * NOTE: Currently, only shmfs/tmpfs is supported for this operation. - * Other filesystems return -ENOSYS. */ static long madvise_remove(struct vm_area_struct *vma, struct vm_area_struct **prev, -- 1.8.3.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbaFXGCm (ORCPT ); Tue, 24 Jun 2014 02:02:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7147 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbaFXGCk (ORCPT ); Tue, 24 Jun 2014 02:02:40 -0400 Date: Tue, 24 Jun 2014 01:59:50 -0400 From: Naoya Horiguchi To: Wang Sheng-Hui Cc: Andrew Morton , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: update the description for madvise_remove Message-ID: <20140624055950.GA12855@nhori.redhat.com> References: <53A9116B.9030004@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53A9116B.9030004@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 24, 2014 at 01:49:31PM +0800, Wang Sheng-Hui wrote: > > Currently, we have more filesystems supporting fallocate, e.g > ext4/btrfs. Remove the outdated comment for madvise_remove. > > Signed-off-by: Wang Sheng-Hui Looks good to me. Reviewed-by: Naoya Horiguchi > --- > mm/madvise.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index a402f8f..0938b30 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma, > /* > * Application wants to free up the pages and associated backing store. > * This is effectively punching a hole into the middle of a file. > - * > - * NOTE: Currently, only shmfs/tmpfs is supported for this operation. > - * Other filesystems return -ENOSYS. > */ > static long madvise_remove(struct vm_area_struct *vma, > struct vm_area_struct **prev, > -- > 1.8.3.2 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753819AbaFXWoi (ORCPT ); Tue, 24 Jun 2014 18:44:38 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:51550 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752714AbaFXWog (ORCPT ); Tue, 24 Jun 2014 18:44:36 -0400 Date: Tue, 24 Jun 2014 15:44:33 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Wang Sheng-Hui , Michael Kerrisk cc: Andrew Morton , Naoya Horiguchi , Johannes Weiner , Andi Kleen , Vladimir Cernov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH] mm: update the description for madvise_remove In-Reply-To: <53A9116B.9030004@gmail.com> Message-ID: References: <53A9116B.9030004@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jun 2014, Wang Sheng-Hui wrote: > > Currently, we have more filesystems supporting fallocate, e.g > ext4/btrfs. Remove the outdated comment for madvise_remove. > > Signed-off-by: Wang Sheng-Hui > --- > mm/madvise.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index a402f8f..0938b30 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma, > /* > * Application wants to free up the pages and associated backing store. > * This is effectively punching a hole into the middle of a file. > - * > - * NOTE: Currently, only shmfs/tmpfs is supported for this operation. > - * Other filesystems return -ENOSYS. > */ > static long madvise_remove(struct vm_area_struct *vma, > struct vm_area_struct **prev, [For those without context: this patch has been merged into the -mm tree.] This reference also exists in the man-page for madvise(2), are you planning on removing it as well?