Re: [PATCH v2] pinctrl: mvebu: add pinctrl drivers for Dove and Kirkwood

[Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>]

On 06/25/2014 08:56 AM, Sascha Hauer wrote:
> On Tue, Jun 24, 2014 at 12:43:48PM +0200, Sebastian Hesselbarth wrote:
>> This adds pinctrl drivers for Marvell Dove and Kirkwood SoCs based
>> on a common driver stub. This design is based on the corresponding
>> Linux driver and should ease additional drivers for Marvell Armada
>> SoCs.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>
> Applied with a small change:
>
>> +static int kirkwood_pinctrl_probe(struct device_d *dev)
>> +{
>> +	const struct of_device_id *match =
>> +		of_match_node(kirkwood_pinctrl_of_match, dev->device_node);
>> +	struct mvebu_pinctrl_soc_info *soc =
>> +		(struct mvebu_pinctrl_soc_info *)match->data;
>> +
>> +	mpp_base = dev_request_mem_region(dev, 0);
>
> I added a return value check here. Not checking it means that the driver
> could do NULL pointer dereferences during runtime.
>
> I should really fix the places where the check is missing in the tree.

Ok, thanks for catching it. Did you also apply the same fix
to Dove's pinctrl stub?

Sebastian


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox