From: Tomasz Figa <t.figa@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
mturquette@linaro.org
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: s3c64xx: Hookup SPI clocks correctly
Date: Wed, 25 Jun 2014 13:29:01 +0200 [thread overview]
Message-ID: <53AAB27D.3030409@samsung.com> (raw)
In-Reply-To: <1403085143-3257-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
Hi Charles,
On 18.06.2014 11:52, Charles Keepax wrote:
> In the move to this clock driver the hookups for the SPI clocks were
> dropped, which causes my system Cragganmore (s3c6410 based) to be unable
> to locate any spibus clocks. This patch adds them back in.
>
> When taking the clock from the epll clock (SCLK) the rates on the SPI
> bus are incorrect, this needs further debugging but the hookup here
> should be correct and the problem should be else where.
>
> The USBCLK case has been dropped because this requires the USB PHY to be
> enabled.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/clk/samsung/clk-s3c64xx.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
Thanks for fixing this. Will apply to my fixes branch.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-06-25 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 9:52 [PATCH] clk: s3c64xx: Hookup SPI clocks correctly Charles Keepax
2014-06-25 11:29 ` Tomasz Figa [this message]
2014-06-30 13:49 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAB27D.3030409@samsung.com \
--to=t.figa@samsung.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.