From: Jeff Liu <jeff.liu@oracle.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [next:master 156/212] fs/binfmt_elf.c:158:18: note: in expansion of macro 'min'
Date: Wed, 25 Jun 2014 19:30:27 +0800 [thread overview]
Message-ID: <53AAB2D3.2050809@oracle.com> (raw)
In-Reply-To: <20140625100213.GA1866@localhost>
On 06/25/2014 18:02 PM, Fengguang Wu wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 30404ddcb1872c8a571fa0889935ff65677e4c78
> commit: aef93cafef35b8830fc973be43f0745f9c16eff4 [156/212] binfmt_elf.c: use get_random_int() to fix entropy depleting
> config: make ARCH=mn10300 asb2364_defconfig
>
> All warnings:
>
> In file included from include/asm-generic/bug.h:13:0,
> from arch/mn10300/include/asm/bug.h:35,
> from include/linux/bug.h:4,
> from include/linux/thread_info.h:11,
> from include/asm-generic/preempt.h:4,
> from arch/mn10300/include/generated/asm/preempt.h:1,
> from include/linux/preempt.h:18,
> from include/linux/spinlock.h:50,
> from include/linux/seqlock.h:35,
> from include/linux/time.h:5,
> from include/linux/stat.h:18,
> from include/linux/module.h:10,
> from fs/binfmt_elf.c:12:
> fs/binfmt_elf.c: In function 'get_atrandom_bytes':
> include/linux/kernel.h:713:17: warning: comparison of distinct pointer types lacks a cast
> (void) (&_min1 == &_min2); \
> ^
>>> fs/binfmt_elf.c:158:18: note: in expansion of macro 'min'
> size_t chunk = min(nbytes, sizeof(random_variable));
I remember we have the same report on arch mn10300 about half a year ago, but the code
is correct. :)
Cheers,
-Jeff
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-06-25 11:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53aa90d2.Yd3WgTmElIsuiwuV%fengguang.wu@intel.com>
2014-06-25 10:02 ` [next:master 156/212] fs/binfmt_elf.c:158:18: note: in expansion of macro 'min' Fengguang Wu
2014-06-25 11:30 ` Jeff Liu [this message]
2014-06-25 19:59 ` Andrew Morton
2014-06-26 1:45 ` Jeff Liu
2014-06-25 22:44 ` David Rientjes
2014-06-26 2:01 ` Jeff Liu
2014-06-26 6:19 ` David Rientjes
2014-06-26 6:33 ` Jeff Liu
2014-06-26 7:47 ` Fengguang Wu
2014-06-30 22:52 ` [patch] binfmt_elf.c: use get_random_int() to fix entropy depleting fix David Rientjes
2014-06-30 23:05 ` Kees Cook
2014-06-30 23:06 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAB2D3.2050809@oracle.com \
--to=jeff.liu@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.