Re: [Qemu-devel] [PATCH v4] mc146818rtc: add rtc-reset-reinjection QMP command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On 06/25/2014 05:40 AM, Michael S. Tsirkin wrote:
> It is necessary to reset RTC interrupt reinjection backlog if
> guest time is synchronized via a different mechanism, such as
> QGA's guest-set-time command.
> 
> Failing to do so causes both corrections to be applied (summed),
> resulting in an incorrect guest time.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Marcelo, is this right?
> 
> Changes from v3:
>     rebase on top of master
>     fixes error code
>     drop dead code
> 
>  qapi-schema.json       | 12 ++++++++++++
>  hw/timer/mc146818rtc.c | 18 ++++++++++++++++++
>  monitor.c              |  7 +++++++
>  qmp-commands.hx        | 23 +++++++++++++++++++++++
>  4 files changed, 60 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]