From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: benoit.canet@irqsave.net, armbru@redhat.com, stefanha@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open()
Date: Wed, 25 Jun 2014 09:49:14 -0600 [thread overview]
Message-ID: <53AAEF7A.8010403@redhat.com> (raw)
In-Reply-To: <1403706959-6979-7-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On 06/25/2014 08:35 AM, Kevin Wolf wrote:
> It doesn't do much any more, we can move the code to bdrv_open() now.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Benoit Canet <benoit@irqsave.net>
> ---
> block.c | 51 +++++++++++----------------------------------------
> 1 file changed, 11 insertions(+), 40 deletions(-)
>
> if (!ret) {
> + bs->growable = 1;
Is it worth converting bs->growable to bool at some point in this
series? But saving it for a separate patch is wise, so:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-25 15:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 14:35 [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1 Kevin Wolf
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 1/9] block: Create bdrv_fill_options() Kevin Wolf
2014-06-25 15:37 ` Eric Blake
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to bdrv_open() Kevin Wolf
2014-06-25 15:40 ` Eric Blake
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 3/9] block: Move json: parsing to bdrv_fill_options() Kevin Wolf
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 4/9] block: Always pass driver name through options QDict Kevin Wolf
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 5/9] block: Use common driver selection code for bdrv_open_file() Kevin Wolf
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open() Kevin Wolf
2014-06-25 15:49 ` Eric Blake [this message]
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion Kevin Wolf
2014-06-25 15:52 ` Eric Blake
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers Kevin Wolf
2014-06-25 15:53 ` Eric Blake
2014-06-25 14:35 ` [Qemu-devel] [PATCH v2 9/9] block: Remove a special case for protocols Kevin Wolf
2014-06-25 15:55 ` Eric Blake
2014-06-26 10:17 ` [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1 Kevin Wolf
2014-06-26 21:17 ` Max Reitz
2014-06-26 21:46 ` Eric Blake
2014-06-26 21:48 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAEF7A.8010403@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.