All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-boot] [Patch v3 3/3] k2hk: change default nand ecc layout
Date: Wed, 25 Jun 2014 18:57:25 +0300	[thread overview]
Message-ID: <53AAF165.8090809@ti.com> (raw)
In-Reply-To: <1403652386.2435.52.camel@snotra.buserror.net>


On 06/25/2014 02:26 AM, Scott Wood wrote:
> On Tue, 2014-06-24 at 16:49 +0300, Ivan Khoronzhuk wrote:
>> For keystyone k2hk board the default nand layout is different
>> from davinci. So swich ecc layout at init in board file.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>>   board/ti/k2hk_evm/board.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/board/ti/k2hk_evm/board.c b/board/ti/k2hk_evm/board.c
>> index ef90f9d..baa6ab7 100644
>> --- a/board/ti/k2hk_evm/board.c
>> +++ b/board/ti/k2hk_evm/board.c
>> @@ -11,6 +11,7 @@
>>   #include <exports.h>
>>   #include <fdt_support.h>
>>   #include <libfdt.h>
>> +#include <nand.h>
>>   
>>   #include <asm/arch/hardware.h>
>>   #include <asm/arch/clock.h>
>> @@ -19,6 +20,7 @@
>>   #include <asm/arch/emac_defs.h>
>>   #include <asm/arch/psc_defs.h>
>>   #include <asm/ti-common/ti-aemif.h>
>> +#include <asm/ti-common/davinci_nand.h>
>>   
>>   DECLARE_GLOBAL_DATA_PTR;
>>   
>> @@ -147,6 +149,15 @@ int cpu_to_bus(u32 *ptr, u32 length)
>>   	return 0;
>>   }
>>   
>> +int board_nand_init(struct nand_chip *chip)
>> +{
>> +	davinci_nand_init(chip);
>> +	chip->ecc.layout =
>> +		board_nand_get_ecclayout(NAND_KEYSTONE_RBL_4BIT_LAYOUT);
> Again, why not use board_nand_set_ecclayout()?
>
> -Scott
>
>

Because oobavail is updated in nand_scan_tail(), which is called later.

Sorry for the mess, but it doesn't matter already, seems I can start 
with default
layout and switch later if needed. So I'm going to remove subj patch.

Thanks.

-- 
Regards,
Ivan Khoronzhuk

      reply	other threads:[~2014-06-25 15:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 13:49 [U-Boot] [U-boot] [Patch v3 0/3] keystone: nand: add additional nand ecclayout Ivan Khoronzhuk
2014-06-24 13:49 ` [U-Boot] [U-boot] [Patch v3 1/3] mtd: nand: davinci: allow to change ecclayout by ecclayout command Ivan Khoronzhuk
2014-08-25 19:14   ` [U-Boot] [U-Boot, U-boot, v3, " Tom Rini
2014-08-25 21:21     ` Ivan Khoronzhuk
2014-06-24 13:49 ` [U-Boot] [U-boot] [Patch v3 2/3] common: cmd_nand: add nand " Ivan Khoronzhuk
2014-08-25 19:14   ` [U-Boot] [U-Boot, U-boot, v3, " Tom Rini
2014-08-25 21:22     ` Ivan Khoronzhuk
2014-08-25 21:48       ` Tom Rini
2014-06-24 13:49 ` [U-Boot] [U-boot] [Patch v3 3/3] k2hk: change default nand ecc layout Ivan Khoronzhuk
2014-06-24 23:26   ` Scott Wood
2014-06-25 15:57     ` Ivan Khoronzhuk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AAF165.8090809@ti.com \
    --to=ivan.khoronzhuk@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.