From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v1 5/9] of: Add NVIDIA Tegra XHCI controller binding Date: Wed, 25 Jun 2014 15:54:56 -0600 Message-ID: <53AB4530.2050106@wwwdotorg.org> References: <1403072180-4944-1-git-send-email-abrestic@chromium.org> <1403072180-4944-6-git-send-email-abrestic@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1403072180-4944-6-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Bresticker , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Thierry Reding , Russell King , Linus Walleij , Greg Kroah-Hartman , Mathias Nyman , Grant Likely , Alan Stern , Kishon Vijay Abraham I , Arnd Bergmann List-Id: linux-tegra@vger.kernel.org On 06/18/2014 12:16 AM, Andrew Bresticker wrote: > Add device-tree binding documentation for the XHCI controller present > on Tegra124 and later SoCs. > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt > + - clock-names: Must include the following entries: > + - xusb_host > + - xusb_falcon_src > + - xusb_ss > + - xusb_ss_src > + - xusb_hs_src > + - xusb_fs_src Looking at include/dt-bindings/clock/tegra124-car.h I see a few entries potentially missing here: #define TEGRA124_CLK_XUSB_HOST_SRC 252 #define TEGRA124_CLK_XUSB_DEV_SRC 256 #define TEGRA124_CLK_XUSB_DEV 257 #define TEGRA124_CLK_XUSB_SS_DIV2 312 > + - pll_u_480m Not just pll_u? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Wed, 25 Jun 2014 15:54:56 -0600 Subject: [PATCH v1 5/9] of: Add NVIDIA Tegra XHCI controller binding In-Reply-To: <1403072180-4944-6-git-send-email-abrestic@chromium.org> References: <1403072180-4944-1-git-send-email-abrestic@chromium.org> <1403072180-4944-6-git-send-email-abrestic@chromium.org> Message-ID: <53AB4530.2050106@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/18/2014 12:16 AM, Andrew Bresticker wrote: > Add device-tree binding documentation for the XHCI controller present > on Tegra124 and later SoCs. > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt > + - clock-names: Must include the following entries: > + - xusb_host > + - xusb_falcon_src > + - xusb_ss > + - xusb_ss_src > + - xusb_hs_src > + - xusb_fs_src Looking at include/dt-bindings/clock/tegra124-car.h I see a few entries potentially missing here: #define TEGRA124_CLK_XUSB_HOST_SRC 252 #define TEGRA124_CLK_XUSB_DEV_SRC 256 #define TEGRA124_CLK_XUSB_DEV 257 #define TEGRA124_CLK_XUSB_SS_DIV2 312 > + - pll_u_480m Not just pll_u? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756944AbaFYVzF (ORCPT ); Wed, 25 Jun 2014 17:55:05 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:55566 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756585AbaFYVzB (ORCPT ); Wed, 25 Jun 2014 17:55:01 -0400 Message-ID: <53AB4530.2050106@wwwdotorg.org> Date: Wed, 25 Jun 2014 15:54:56 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andrew Bresticker , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Thierry Reding , Russell King , Linus Walleij , Greg Kroah-Hartman , Mathias Nyman , Grant Likely , Alan Stern , Kishon Vijay Abraham I , Arnd Bergmann Subject: Re: [PATCH v1 5/9] of: Add NVIDIA Tegra XHCI controller binding References: <1403072180-4944-1-git-send-email-abrestic@chromium.org> <1403072180-4944-6-git-send-email-abrestic@chromium.org> In-Reply-To: <1403072180-4944-6-git-send-email-abrestic@chromium.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2014 12:16 AM, Andrew Bresticker wrote: > Add device-tree binding documentation for the XHCI controller present > on Tegra124 and later SoCs. > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt > + - clock-names: Must include the following entries: > + - xusb_host > + - xusb_falcon_src > + - xusb_ss > + - xusb_ss_src > + - xusb_hs_src > + - xusb_fs_src Looking at include/dt-bindings/clock/tegra124-car.h I see a few entries potentially missing here: #define TEGRA124_CLK_XUSB_HOST_SRC 252 #define TEGRA124_CLK_XUSB_DEV_SRC 256 #define TEGRA124_CLK_XUSB_DEV 257 #define TEGRA124_CLK_XUSB_SS_DIV2 312 > + - pll_u_480m Not just pll_u?