From: Dave Hansen <dave.hansen@intel.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: catch memory commitment underflow
Date: Wed, 25 Jun 2014 15:23:45 -0700 [thread overview]
Message-ID: <53AB4BF1.3000504@intel.com> (raw)
In-Reply-To: <20140624201614.18273.39034.stgit@zurg>
On 06/24/2014 01:16 PM, Konstantin Khlebnikov wrote:
> reserve;
>
> +#ifdef CONFIG_DEBUG_VM
> + WARN_ONCE(percpu_counter_read(&vm_committed_as) <
> + -(s64)vm_committed_as_batch * num_online_cpus(),
> + "memory commitment underflow");
> +#endif
Why not use VM_WARN_ON_ONCE()?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: catch memory commitment underflow
Date: Wed, 25 Jun 2014 15:23:45 -0700 [thread overview]
Message-ID: <53AB4BF1.3000504@intel.com> (raw)
In-Reply-To: <20140624201614.18273.39034.stgit@zurg>
On 06/24/2014 01:16 PM, Konstantin Khlebnikov wrote:
> reserve;
>
> +#ifdef CONFIG_DEBUG_VM
> + WARN_ONCE(percpu_counter_read(&vm_committed_as) <
> + -(s64)vm_committed_as_batch * num_online_cpus(),
> + "memory commitment underflow");
> +#endif
Why not use VM_WARN_ON_ONCE()?
next prev parent reply other threads:[~2014-06-25 22:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 20:16 [PATCH 1/3] shmem: fix double uncharge in __shmem_file_setup() Konstantin Khlebnikov
2014-06-24 20:16 ` Konstantin Khlebnikov
2014-06-24 20:16 ` [PATCH 2/3] shmem: update memory reservation on truncate Konstantin Khlebnikov
2014-06-24 20:16 ` Konstantin Khlebnikov
2014-06-26 3:53 ` Hugh Dickins
2014-06-26 3:53 ` Hugh Dickins
2014-06-26 11:27 ` Konstantin Khlebnikov
2014-06-26 11:27 ` Konstantin Khlebnikov
2014-06-24 20:16 ` [PATCH 3/3] mm: catch memory commitment underflow Konstantin Khlebnikov
2014-06-24 20:16 ` Konstantin Khlebnikov
2014-06-25 22:03 ` Andrew Morton
2014-06-25 22:03 ` Andrew Morton
2014-06-26 4:08 ` Konstantin Khlebnikov
2014-06-26 4:08 ` Konstantin Khlebnikov
2014-06-25 22:23 ` Dave Hansen [this message]
2014-06-25 22:23 ` Dave Hansen
2015-01-18 11:34 ` Sasha Levin
2015-01-18 11:34 ` Sasha Levin
2015-01-18 18:36 ` Konstantin Khlebnikov
2015-01-18 18:36 ` Konstantin Khlebnikov
2015-04-25 2:15 ` Sasha Levin
2015-04-25 2:15 ` Sasha Levin
2015-06-07 14:29 ` Sasha Levin
2015-06-07 14:29 ` Sasha Levin
2014-06-26 3:44 ` [PATCH 1/3] shmem: fix double uncharge in __shmem_file_setup() Hugh Dickins
2014-06-26 3:44 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AB4BF1.3000504@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.