From: Daniel Mack <daniel@zonque.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, zonque@gmail.com
Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix S24_LE and U24_LE support
Date: Thu, 26 Jun 2014 09:29:42 +0200 [thread overview]
Message-ID: <53ABCBE6.7040906@zonque.org> (raw)
In-Reply-To: <1403759364-14524-1-git-send-email-peter.ujfalusi@ti.com>
On 06/26/2014 07:09 AM, Peter Ujfalusi wrote:
> In case of S24_LE/U24_LE modes we expect 24bits on the bus while the samples
> are stored and transferred in memory on 32bits (lower 3 bytes of the 4
> bytes).
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: Daniel Mack <daniel@zonque.org>
Thanks!
Daniel
> ---
> sound/soc/davinci/davinci-mcasp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 9afb14629a17..6d5de26eae2f 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -720,6 +720,10 @@ static int davinci_mcasp_hw_params(struct snd_pcm_substream *substream,
>
> case SNDRV_PCM_FORMAT_U24_LE:
> case SNDRV_PCM_FORMAT_S24_LE:
> + dma_params->data_type = 4;
> + word_length = 24;
> + break;
> +
> case SNDRV_PCM_FORMAT_U32_LE:
> case SNDRV_PCM_FORMAT_S32_LE:
> dma_params->data_type = 4;
>
next prev parent reply other threads:[~2014-06-26 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 5:09 [PATCH] ASoC: davinci-mcasp: Fix S24_LE and U24_LE support Peter Ujfalusi
2014-06-26 7:29 ` Daniel Mack [this message]
2014-06-30 14:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ABCBE6.7040906@zonque.org \
--to=daniel@zonque.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.