From: Maurizio Lombardi <mlombard@redhat.com>
To: Jack Wang <xjtuwjp@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>
Cc: lindar_liu@usish.com,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once
Date: Thu, 26 Jun 2014 10:20:04 +0200 [thread overview]
Message-ID: <53ABD7B4.5070804@redhat.com> (raw)
In-Reply-To: <53ABD51C.5050806@gmail.com>
On 06/26/2014 10:09 AM, Jack Wang wrote:
> Thanks Rickard,
>
> From my point of view, looks good, but I'd like to get review from Anand
> (cc-ed).
I would like to add that I noticed that this fields is only set and appears to be never used,
maybe it could be completely removed.
Regards,
Maurizio Lombardi
next prev parent reply other threads:[~2014-06-26 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 14:01 [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-25 15:34 ` Maurizio Lombardi
[not found] ` <CAN7X1Un3-u-Q428-s1dYk5z4P-Bb=jO-N+x1T+PLhH1fDE1MRw@mail.gmail.com>
2014-06-25 16:08 ` Maurizio Lombardi
2014-06-26 8:09 ` Jack Wang
2014-06-26 8:20 ` Maurizio Lombardi [this message]
2014-06-27 9:06 ` Suresh Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ABD7B4.5070804@redhat.com \
--to=mlombard@redhat.com \
--cc=AnandKumar.Santhanam@pmcs.com \
--cc=JBottomley@parallels.com \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.