From: Maurizio Lombardi <mlombard@redhat.com>
To: Joe Perches <joe@perches.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Eddie Wai <eddie.wai@broadcom.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once
Date: Thu, 26 Jun 2014 14:12:26 +0200 [thread overview]
Message-ID: <53AC0E2A.4040907@redhat.com> (raw)
In-Reply-To: <1403784303.7977.38.camel@joe-AO725>
On 06/26/2014 02:05 PM, Joe Perches wrote:
> On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
>> A struct member variable is set to different values without having used in between.
> []
>> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> []
>> @@ -1643,12 +1643,11 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn,
>> stats->r2t_pdus = conn->r2t_pdus_cnt;
>> stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt;
>> stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt;
>> - stats->custom_length = 3;
>> strcpy(stats->custom[2].desc, "eh_abort_cnt");
>> stats->custom[2].value = conn->eh_abort_cnt;
>> stats->digest_err = 0;
>> stats->timeout_err = 0;
>> - stats->custom_length = 0;
>> + stats->custom_length = 3;
>
> You are changing custom_length from 0 to 3.
>
> Why is this correct?
http://marc.info/?l=linux-scsi&m=140371670511706&w=2
next prev parent reply other threads:[~2014-06-26 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 11:54 [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-26 12:05 ` Joe Perches
2014-06-26 12:12 ` Maurizio Lombardi [this message]
2014-06-26 12:17 ` Joe Perches
2014-06-26 12:14 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AC0E2A.4040907@redhat.com \
--to=mlombard@redhat.com \
--cc=JBottomley@parallels.com \
--cc=eddie.wai@broadcom.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.