On 06/23/2014 06:32 AM, Chrysostomos Nanakos wrote: > VM Image on Archipelago volume is specified like this: > > file=archipelago:[/mport=[:vport=][: > segment=]] > > or > > file.driver=archipelago,file.volume=[,file.mport=[, > file.vport=][,file.segment=]] > I still plan to review this series in full, but my quick pre-review comment: on version 2, Markus suggested that you should separate the patch that adds QMP structured options (first) from the patch that adds syntactic sugar file=archipelago:[/mport=[:vport=]] (second) https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00269.html and I stand by his suggestion, although I don't see that split here yet. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org