From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0BJt-0001Zn-Pj for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0BJl-0000zD-2A for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:10:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45393 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0BJj-0000yo-HI for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:10:28 -0400 Message-ID: <53AC37E2.5060203@suse.de> Date: Thu, 26 Jun 2014 17:10:26 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1403793009-54176-1-git-send-email-jfrei@linux.vnet.ibm.com> <1403793009-54176-4-git-send-email-jfrei@linux.vnet.ibm.com> <53AC2FCE.4020404@suse.de> <53AC3779.1060606@linux.vnet.ibm.com> In-Reply-To: <53AC3779.1060606@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] pc-bios/s390-ccw: handle different sector sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Eugene \"jno\" Dvurechenski" , Jens Freimann , Christian Borntraeger , Cornelia Huck Cc: qemu-devel@nongnu.org On 26.06.14 17:08, Eugene "jno" Dvurechenski wrote: > > On 06/26/2014 06:35 PM, Alexander Graf wrote: >>> - ns_end = sec + SECTOR_SIZE; >>> + ns_end = sec + virtio_get_block_size(); > ... >>> -#define SECTOR_SIZE 512 >>> +#define SECTOR_SIZE 4096 >> Why keep the define at all? > Just to use as default value and in storage allocation (and similar > static calculations) now. Then either rename it MAX_SECTOR_SIZE and audit every single use of it or try to convert everything to be dynamically sized - gcc should be able to create arrays on the stack based on variables. Alex