From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc Marí" <marc.mari.barcelo@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API
Date: Thu, 26 Jun 2014 17:35:21 +0200 [thread overview]
Message-ID: <53AC3DB9.7020101@redhat.com> (raw)
In-Reply-To: <20140626172735.61327704@crunchbang>
Il 26/06/2014 17:27, Marc Marí ha scritto:
> If these functions are just Virtio PCI specific, it makes sense to take
> them out. If they are common to other transports, in my opinion is
> better to leave them there. Of course, a good solution has to be found
> to just having a global bus variable.
>
> It is also interesting to see that the current
> implementation of qpci_device_foreach does only work in one bus, so
> probably is not so terrible to have it as global and unique.
qpci_device_foreach works for one bus only because libqos doesn't
support PCI bridges. But it lets you specify the PCI bus of interest,
and it seems a good idea to have this in the virtio-pci implementation.
Paolo
next prev parent reply other threads:[~2014-06-26 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 14:34 [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API Marc Marí
2014-06-26 15:09 ` Paolo Bonzini
2014-06-26 15:27 ` Marc Marí
2014-06-26 15:35 ` Paolo Bonzini [this message]
2014-06-26 16:44 ` Fam Zheng
2014-06-30 7:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AC3DB9.7020101@redhat.com \
--to=pbonzini@redhat.com \
--cc=marc.mari.barcelo@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.