From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v01 2/3] xen/arm: add platform specific
 definitions for DRA7 evm board
Date: Thu, 26 Jun 2014 17:40:25 +0100
Message-ID: <53AC4CF9.8010003@linaro.org>
References: <1403781330-22504-1-git-send-email-andrii.tseglytskyi@globallogic.com>
	<1403781330-22504-3-git-send-email-andrii.tseglytskyi@globallogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1403781330-22504-3-git-send-email-andrii.tseglytskyi@globallogic.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrii Tseglytskyi <andrii.tseglytskyi@globallogic.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Andrii,

Thank you for the patch.

On 06/26/2014 12:15 PM, Andrii Tseglytskyi wrote:

> +static int __init dra7_smp_init(void)
> +{
> +    void __iomem *wugen_base;
> +
> +    wugen_base = ioremap_nocache(DRA7_WKUPGEN_BASE, PAGE_SIZE);
> +    if ( !wugen_base )
> +    {
> +        dprintk(XENLOG_ERR, "Unable to map omap5 MMIO\n");
> +        return -EFAULT;
> +    }
> +#ifndef NDEBUG
> +    printk("Set AuxCoreBoot1 to %"PRIpaddr" (%p)\n",
> +           __pa(init_secondary), init_secondary);
> +#endif
> +    writel(__pa(init_secondary), wugen_base + DRA7_AUX_CORE_BOOT_1_OFFSET);
> +#ifndef NDEBUG
> +    printk("Set AuxCoreBoot0 to 0x20\n");
> +#endif

I think those 2 printk would be useful even in non-debug mode. If you
don't want to print them all the time, you can use
printk(XENLOG_DEBUG "your msg")

> +    writel(0x20, wugen_base + DRA7_AUX_CORE_BOOT_0_OFFSET);
> +
> +    iounmap(wugen_base);
> +
> +    return 0;
> +}
> +
> +static const char const *dra7_dt_compat[] __initdata =

This should be __initconst.

> +PLATFORM_START(dra7, "TI DRA7")
> +    .compatible = dra7_dt_compat,
> +    .init_time = dra7_init_time,
> +    .cpu_up = cpu_up_send_sgi,
> +    .smp_init = dra7_smp_init,
> +
> +    .dom0_gnttab_start = 0x4b000000,
> +    .dom0_gnttab_size = 0x20000,
> +    .blacklist_dev = dra7xx_blacklist_dev,
> +PLATFORM_END

Any plan to support reset callback?

Regards,

-- 
Julien Grall