All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Andreas Färber" <andreas.faerber@web.de>, patches@linaro.org
Subject: Re: [Qemu-devel] [RFC UNTESTED] tcg/ppc: Fix support for 64-bit PPC MacOSX hosts
Date: Thu, 26 Jun 2014 12:51:11 -0700	[thread overview]
Message-ID: <53AC79AF.9030307@twiddle.net> (raw)
In-Reply-To: <1403797037-20734-1-git-send-email-peter.maydell@linaro.org>

On 06/26/2014 08:37 AM, Peter Maydell wrote:
> +++ b/tcg/ppc/tcg-target.c
> @@ -1716,6 +1716,9 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, bool is_64)
>  # define LINK_AREA_SIZE                (6 * SZR)
>  # define LR_OFFSET                     (1 * SZR)
>  # define TCG_TARGET_CALL_STACK_OFFSET  (LINK_AREA_SIZE + 8 * SZR)
> +#elif defined(TCG_TARGET_CALL_DARWIN)
> +# define LINK_AREA_SIZE                (6 * SZR)
> +# define LR_OFFSET                     (2 * SZR)
>  #elif TCG_TARGET_REG_BITS == 64

Reviewed-by: Richard Henderson <rth@twiddle.net>

It does indeed give the same layout as before for darwin.


r~

  reply	other threads:[~2014-06-26 19:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26 15:37 [Qemu-devel] [RFC UNTESTED] tcg/ppc: Fix support for 64-bit PPC MacOSX hosts Peter Maydell
2014-06-26 19:51 ` Richard Henderson [this message]
2014-06-29  0:01 ` Andreas Färber
2014-06-29 10:39   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AC79AF.9030307@twiddle.net \
    --to=rth@twiddle.net \
    --cc=andreas.faerber@web.de \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.