From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 26 Jun 2014 21:55:37 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:62097 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6860035AbaFZTzfSzZ0f (ORCPT ); Thu, 26 Jun 2014 21:55:35 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 322F19D27BE1E; Thu, 26 Jun 2014 20:55:24 +0100 (IST) Received: from KLMAIL02.kl.imgtec.org (10.40.10.222) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.181.6; Thu, 26 Jun 2014 20:55:28 +0100 Received: from hhmail02.hh.imgtec.org (10.100.10.20) by klmail02.kl.imgtec.org (10.40.10.222) with Microsoft SMTP Server (TLS) id 14.3.181.6; Thu, 26 Jun 2014 20:55:27 +0100 Received: from BAMAIL02.ba.imgtec.org (192.168.66.28) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.181.6; Thu, 26 Jun 2014 20:55:27 +0100 Received: from [10.20.2.221] (10.20.2.221) by bamail02.ba.imgtec.org (192.168.66.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 26 Jun 2014 12:55:25 -0700 Message-ID: <53AC7AAD.7010007@imgtec.com> Date: Thu, 26 Jun 2014 12:55:25 -0700 From: Deng-Cheng Zhu User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: David Daney CC: , , , , , , Subject: Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_" References: <1403809900-17454-1-git-send-email-dengcheng.zhu@imgtec.com> <1403809900-17454-6-git-send-email-dengcheng.zhu@imgtec.com> <53AC7466.6070401@gmail.com> In-Reply-To: <53AC7466.6070401@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.2.221] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 40860 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: dengcheng.zhu@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 06/26/2014 12:28 PM, David Daney wrote: > On 06/26/2014 12:11 PM, Deng-Cheng Zhu wrote: >> From: Deng-Cheng Zhu >> >> Since all the files are in arch/mips/kvm/, there's no need of the prefixes >> "kvm_" and "kvm_mips_". >> > > I don't like this change. > > It will leads me to confuse arch/mips/kvm/interrupt.h with > include/linux/interrupt.h We have and "interrupt.h". > > x86 calls these things irq.c and irq.h, perhaps that would be a little > better. There's also include/linux/irq.h > > There is precedence in x86 for some of the names though. > > But really why churn up the code in the first place? the kvm_mips prefix > does tell us exactly what we are dealing with. That's why people created the arch/mips/kvm directory, isn't it? Deng-Cheng From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:62097 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6860035AbaFZTzfSzZ0f (ORCPT ); Thu, 26 Jun 2014 21:55:35 +0200 Message-ID: <53AC7AAD.7010007@imgtec.com> Date: Thu, 26 Jun 2014 12:55:25 -0700 From: Deng-Cheng Zhu MIME-Version: 1.0 Subject: Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_" References: <1403809900-17454-1-git-send-email-dengcheng.zhu@imgtec.com> <1403809900-17454-6-git-send-email-dengcheng.zhu@imgtec.com> <53AC7466.6070401@gmail.com> In-Reply-To: <53AC7466.6070401@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: David Daney Cc: pbonzini@redhat.com, gleb@kernel.org, kvm@vger.kernel.org, sanjayl@kymasys.com, james.hogan@imgtec.com, ralf@linux-mips.org, linux-mips@linux-mips.org Message-ID: <20140626195525.Lbke_jcNtZ6r4C5bzKXpNinfXptBvUrChY4bR4wO8tM@z> On 06/26/2014 12:28 PM, David Daney wrote: > On 06/26/2014 12:11 PM, Deng-Cheng Zhu wrote: >> From: Deng-Cheng Zhu >> >> Since all the files are in arch/mips/kvm/, there's no need of the prefixes >> "kvm_" and "kvm_mips_". >> > > I don't like this change. > > It will leads me to confuse arch/mips/kvm/interrupt.h with > include/linux/interrupt.h We have and "interrupt.h". > > x86 calls these things irq.c and irq.h, perhaps that would be a little > better. There's also include/linux/irq.h > > There is precedence in x86 for some of the names though. > > But really why churn up the code in the first place? the kvm_mips prefix > does tell us exactly what we are dealing with. That's why people created the arch/mips/kvm directory, isn't it? Deng-Cheng