From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joshua Whitehead Subject: Re: [RFC PATCH 2/4] Add cbs parameter support to xl tool stack, remove defunct sedf parameters Date: Thu, 26 Jun 2014 15:55:59 -0400 Message-ID: <53AC7ACF.5010502@dornerworks.com> References: <1402689488-3577-1-git-send-email-josh.whitehead@dornerworks.com> <1402689488-3577-3-git-send-email-josh.whitehead@dornerworks.com> <1403017353.16864.148.camel@Solace> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1403017353.16864.148.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Ian Campbell , Stefano Stabellini , George Dunlap , Ian Jackson , Robert VanVossen , Xen-devel , Nate Studer List-Id: xen-devel@lists.xenproject.org On 6/17/2014 11:02 AM, Dario Faggioli wrote: > The core of this patch, as well as of patches 3 and 4, is renaming > *_sedf to *_cbs, on which I think I commented already... let's see where > that discussion goes. > > So, leaving the renaming part aside... > > On ven, 2014-06-13 at 15:58 -0400, Josh Whitehead wrote: >> From: Robbie VanVossen >> >> --- >> docs/man/xl.cfg.pod.5 | 9 ++---- >> tools/libxc/xc_sedf.c | 16 +++------- >> tools/libxc/xenctrl.h | 12 +++---- >> tools/libxl/libxl.c | 31 ++++++------------- >> tools/libxl/libxl.h | 3 +- >> tools/libxl/libxl_create.c | 61 ------------------------------------ >> tools/libxl/libxl_types.idl | 3 +- >> tools/libxl/xl_cmdimpl.c | 62 ++++++++++--------------------------- >> tools/libxl/xl_cmdtable.c | 8 ++--- >> tools/python/xen/lowlevel/xc/xc.c | 34 +++++++++----------- >> xen/include/public/domctl.h | 4 +-- >> > What we usually do is splitting the series so that you cross the various > components' boundaries as few as possible. > > That means, for instance, in this case, having one (or more) patch(es) > modifying libxc, one or more modifying libxl and, if possible, one or > more modifying xl. > > That is, mostly, for making the review easier, but also because it may > be that different components are under the umbrella of different > maintainer and/or committers. > > When modifying libxl, please mind the issue of API stability that I > brought up in this thread already. > Our intention had been to isolate components with each of the patches, but apparently we did not subdivide those components as far as we needed. This should be a simple enough fix for V2 of the patch to properly split along component boundaries (as well as further reorganization of the patch that has been discussed in other threads). >> 11 files changed, 58 insertions(+), 185 deletions(-) >> mode change 100644 => 100755 docs/man/xl.cfg.pod.5 >> mode change 100644 => 100755 tools/libxc/xc_sedf.c >> mode change 100644 => 100755 tools/libxc/xenctrl.h >> mode change 100644 => 100755 tools/libxl/libxl.c >> mode change 100644 => 100755 tools/libxl/libxl.h >> mode change 100644 => 100755 tools/libxl/libxl_types.idl >> mode change 100644 => 100755 tools/libxl/xl_cmdimpl.c >> mode change 100644 => 100755 tools/libxl/xl_cmdtable.c >> mode change 100644 => 100755 tools/python/xen/lowlevel/xc/xc.c >> mode change 100644 => 100755 xen/include/public/domctl.h >> > What are these? I really don't think they should be here. > Apologies for this, these permissions changes were not intended to go out to the list as they were a side effect of something else we were working on, we'll remove these for V2 of the patch. Thanks. - Josh Whitehead > Regards, > Dario >