Re: [Qemu-devel] [PATCH for 2.1 v3 0/2] block: Fix unset "filename" for certain drivers

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

On 06/26/2014 03:38 PM, Max Reitz wrote:
> For some protocol block drivers, the "filename" attribute in their BDSs
> is unset due to bdrv_file_open() removing it from the options QDict
> before bdrv_open_common() is able to copy it into the BDS. Fix this by
> not removing it until until bdrv_open_common() has indeed copied it.
> 
> 
> v3:
>  - Patch 1: Rebased onto Kevin's block branch, especially his series
>    "bdrv_open() cleanups, part 1" [Eric]

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>


> Max Reitz (2):
>   block: Do not prematurely remove "filename"
>   iotests: Add test for set "filename" for NBD
> 
>  block.c                    | 35 ++++++++++++++++++----
>  tests/qemu-iotests/097     | 72 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/097.out | 13 +++++++++
>  tests/qemu-iotests/group   |  1 +
>  4 files changed, 115 insertions(+), 6 deletions(-)
>  create mode 100755 tests/qemu-iotests/097
>  create mode 100644 tests/qemu-iotests/097.out
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]